New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796127 link

Starred by 10 users

1.1%-21% regression in system_health.memory_desktop at 522550:522732

Project Member Reported by mlippautz@chromium.org, Dec 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 19 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=796127

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2e8688017bfe115d69d15260872c38ff186dbee365e66f6182509dcdec869f7b


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
win-high-dpi
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Dec 19 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/149346b6040000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 19 2017

Cc: haraken@chromium.org peria@chromium.org rmcilroy@chromium.org
Owner: peria@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/149346b6040000

gin: Set V8 context snapshot as a default snapshot
By peria@chromium.org ยท Fri Dec 08 01:06:33 2017
chromium @ 231de835ae50977881282c8c7fbbc2a93388d4b6

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Dec 19 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12ff828e040000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Dec 19 2017

๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12ff828e040000

gin: Set V8 context snapshot as a default snapshot
By peria@chromium.org ยท Fri Dec 08 01:06:33 2017
chromium @ 231de835ae50977881282c8c7fbbc2a93388d4b6

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 6 by peria@chromium.org, Dec 22 2017

Labels: -Performance-Sheriff-V8

Comment 7 by peria@chromium.org, Dec 22 2017

 Issue 796126  has been merged into this issue.

Comment 8 by peria@chromium.org, Dec 22 2017

Cc: kraynov@chromium.org
 Issue 794984  has been merged into this issue.

Comment 9 by peria@chromium.org, Dec 22 2017

Cc: khushals...@chromium.org chrishtr@chromium.org fmeawad@google.com tsepez@chromium.org
 Issue 794305  has been merged into this issue.

Comment 10 by peria@chromium.org, Jan 15 2018

Cc: yukishiino@chromium.org benhenry@google.com
 Issue 801731  has been merged into this issue.

Comment 11 by peria@chromium.org, Jan 15 2018

Cc: jgruber@chromium.org b...@b6n.ch cbruni@chromium.org
 Issue 801546  has been merged into this issue.

Comment 12 by peria@chromium.org, Jan 15 2018

Cc: robliao@chromium.org
 Issue 796846  has been merged into this issue.

Comment 13 by peria@chromium.org, Jan 15 2018

Cc: jarin@chromium.org ulan@google.com wolenetz@chromium.org bmeu...@chromium.org
 Issue 764617  has been merged into this issue.

Comment 14 by peria@chromium.org, Jan 18 2018

Cc: hpayer@chromium.org
 Issue 803040  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b550792f0f9357f380d501288f368e85d43279b8

commit b550792f0f9357f380d501288f368e85d43279b8
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Tue Jan 23 11:00:01 2018

chrome: Unship snapshot_blob.bin from Win/Mac/Linux

We are shipping snapshot_blob.bin and v8_context_snapshot.bin with
Chrome for speed up of launching V8 environments.
Beside it, v8_context_snapshot.bin contains all information in
snapshot_blob.bin, and we no longer need snapshot_blob.bin if
v8_context_snapshot.bin is available.

This CL drops snapshot_blob.bin from Chrome for such platforms
to reduce the size of shipping binaries and memory usages.


Bug:  789964 ,  796127 
Change-Id: I4c17f803212b845b2021936d7eb1eec913d76c68
Reviewed-on: https://chromium-review.googlesource.com/812587
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531204}
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/BUILD.gn
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/tools/build/linux/FILES.cfg
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/tools/build/mac/FILES.cfg
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/chrome/tools/build/win/FILES.cfg
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/content/app/content_main_runner.cc
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/content/public/app/mojo/content_utility_manifest.json
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/content/shell/BUILD.gn
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/extensions/shell/BUILD.gn
[modify] https://crrev.com/b550792f0f9357f380d501288f368e85d43279b8/extensions/shell/installer/linux/common/installer.include

Comment 16 by peria@chromium.org, Jan 24 2018

Cc: petermarshall@chromium.org roc...@chromium.org kinuko@chromium.org
 Issue 804253  has been merged into this issue.

Comment 17 by peria@chromium.org, Jan 24 2018

 Issue 804254  has been merged into this issue.

Comment 18 by peria@chromium.org, Jan 24 2018

Status: WontFix (was: Assigned)
We replaced snapshot files to improve the performance of launching V8 in Blink.
The new snapshot file is 400-500kB larger than the old one, so this regression is expected.

Comment 19 by peria@chromium.org, Jan 25 2018

 Issue 805334  has been merged into this issue.

Comment 20 by peria@chromium.org, Jan 25 2018

 Issue 805335  has been merged into this issue.

Comment 21 by peria@chromium.org, Jan 25 2018

 Issue 805362  has been merged into this issue.

Comment 22 by peria@chromium.org, Jan 25 2018

 Issue 805559  has been merged into this issue.

Sign in to add a comment