New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796118 link

Starred by 3 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Mar 2018
Cc:
█ rpattumani@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Hand pointer is seen instead of I-beam pointer on hovering mouse on 'SIM card is Locked' message in chrome://settings page

Project Member Reported by mmanchala@chromium.org, Dec 19 2017 
Chrome Version:  63.0.3239.116/ 10032.75.0  stable-channel Daisy,Reks and Candy
OS: Chrome

What steps will reproduce the problem?
1)Sign into User ->Insert Mobile Dongle and ensure it is connected
2)In chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page ->Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> Enter correct pin and click 'ENTER'
3)Now remove dongle and again insert Mobile Dongle-> Observe 'SIM card is Locked' message is seen ->now hover mouse on Text and observe hand pointer is seen (Please refer video and screenshot)

Expected:  I-beam pointer should be seen on hovering mouse on 'SIM card is Locked' message
Actual: Instead Hand pointer is seen on hovering mouse on 'SIM card is Locked' message and on clicking nothing happens 

This is Regression issue as same is working fine in M-56

@stevenjb : Please confirm the issue

Note: Issue is seen on M-65  also
Actual_HandPointer.webm
424 KB View Download
Actual_HandPointer.jpg
481 KB View Download
Expected_IBeamPointer.webm
578 KB View Download
Expected_IBeamPointer.jpg
811 KB View Download

Comment 1 by steve...@chromium.org, Dec 19 2017

Cc: tbuck...@chromium.org bettes@chromium.org
Labels: -Pri-1 Pri-3
This is kind of subtle.

Normally that row is actionable - clicking on it would show the Mobile Network subpage or Cellular Details page. Actionable rows show the 'hand'.

Since the sim card is locked, there is no 'action', until/unless the 'unlock' button is used to unlock the sim.

We have a few options here:
1. Leave it as-is.
2. Toggle the 'actionable' state whenever the action is disabled (there are a few other potential other edge cases we would need to cover). This would show the i-beam cursor over text instead of the hand when the action is disable.
3. Make 'unlock' the action here (although that would be consistent with other UI with a button instead of a toggle)

bettes@ - what do you suggest?

Note: This seems pretty low priority to me.

Comment 2 by dsunk...@chromium.org, Jan 30 2018

Cc: rpattumani@chromium.org

Comment 3 by steve...@chromium.org, Feb 1 2018

Labels: -M-65 M-66
Summary: Hand pointer is seen instead of I-beam pointer on hovering mouse on 'SIM card is Locked' message in chrome://settings page (was: Regression : Hand pointer is seen instead of I-beam pointer on hovering mouse on 'SIM card is Locked' message in chrome://settings page)

Comment 4 by steve...@chromium.org, Mar 6 2018

Status: Started (was: Assigned)

Comment 5 by steve...@chromium.org, Mar 7 2018 

For now, just using the default pointer for the siminfo element (which will be overridden by the embedded 'unlock', 'change pin', or toggle buttons).
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c76d9a204c2ea122d3330c98481cbe77371802fd

commit c76d9a204c2ea122d3330c98481cbe77371802fd
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Mar 07 16:37:23 2018

Network config: use default cursor for siminfo

Bug:  796118 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e239ddd5430350d8a76a33f1dd5ffbaf4d3317f
Reviewed-on: https://chromium-review.googlesource.com/952523
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541459}
[modify] https://crrev.com/c76d9a204c2ea122d3330c98481cbe77371802fd/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html

Comment 7 by steve...@chromium.org, Mar 7 2018

Labels: -M-66 M-67
Status: Fixed (was: Started)

Comment 8 by mmanchala@chromium.org, Oct 4 

Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy. Arrow pointer is seen for 'SIM card is Locked' message

Thanks..!!
►

Sign in to add a comment