New issue
Advanced search Search tips

Issue 796109 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 688342



Sign in to add a comment

Convert load expectation in tracing metrics to cover TimeToInteractive instead of First Contentful Paint

Project Member Reported by nedngu...@google.com, Dec 19 2017

Issue description

TimeToInteractive is the top level metrics of loading, so it makes more sense to look at this whole span instead of just from Navigation to First Contentful Paint. 
 
Blocking: 688342
Cc: dpranke@chromium.org
 Issue 797179  has been merged into this issue.
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Dec 23 2017

Detected 5 new flakes for test/step "archive_webkit_tests_results". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxhcmNoaXZlX3dlYmtpdF90ZXN0c19yZXN1bHRzDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Jan 2 2018

Detected 3 new flakes for test/step "archive_webkit_tests_results". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxhcmNoaXZlX3dlYmtpdF90ZXN0c19yZXN1bHRzDA. This message was posted automatically by the chromium-try-flakes app.
Status: Started (was: Assigned)
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Jan 5 2018

Detected 4 new flakes for test/step "archive_webkit_tests_results". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxhcmNoaXZlX3dlYmtpdF90ZXN0c19yZXN1bHRzDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Jan 9 2018

Detected 10 new flakes for test/step "archive_webkit_tests_results". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxhcmNoaXZlX3dlYmtpdF90ZXN0c19yZXN1bHRzDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, Jan 10 2018

Detected 4 new flakes for test/step "archive_webkit_tests_results". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxhcmNoaXZlX3dlYmtpdF90ZXN0c19yZXN1bHRzDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 9 by chromium...@appspot.gserviceaccount.com, Jan 11 2018

Detected 13 new flakes for test/step "archive_webkit_tests_results". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxhcmNoaXZlX3dlYmtpdF90ZXN0c19yZXN1bHRzDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a1536b0c3a6e3850077d500c5a363af884af9a5f

commit a1536b0c3a6e3850077d500c5a363af884af9a5f
Author: Mythri Alle <mythria@chromium.org>
Date: Fri Feb 09 13:27:23 2018

Update load expectations to use time to interactive

Load expectations uses first contentful paint events to determine
load expectations. This is not representative of loading and it
is better to use time to interactive instead. Time to interactive
is already used by the loading metric. This cl moves the computation
of time to interactive to load expectation and updates loading metric
to use load expectations to obtain loading related metrics.


Bug:  chromium:796109 
Change-Id: Ic75d8ca78a66103e101b66201b0fa49a76f38d8b
Reviewed-on: https://chromium-review.googlesource.com/897491
Reviewed-by: Deepanjan Roy <dproy@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>

[rename] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/extras/chrome/event_finder_utils.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/trace_viewer.gypi
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/metrics/system_health/loading_metric.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/importer/user_model_builder_test.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/metrics/v8/runtime_stats_metric_test.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/metrics/system_health/power_metric_test.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/metrics/system_health/loading_metric_test.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/extras/chrome/estimated_input_latency_test.html
[rename] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/extras/chrome/event_finder_utils_test.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/importer/find_load_expectations.html
[rename] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/extras/chrome/time_to_interactive_test.html
[rename] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/extras/chrome/time_to_interactive.html
[modify] https://crrev.com/a1536b0c3a6e3850077d500c5a363af884af9a5f/tracing/tracing/model/user_model/load_expectation.html

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f73167a6894a911709d1d6c88f1bc97cb133de33

commit f73167a6894a911709d1d6c88f1bc97cb133de33
Author: Mythri Alle <mythria@chromium.org>
Date: Wed Mar 14 10:07:07 2018

Ignore i-frame navigationStart events when computing LoadExpectation

We seem to have navigationStart events corresponding to i-frames that
are reported as navigationStarts for main frame with a blank url ('').
These events have to be ignored, so that we don't have overlapping
loading expectations.

Also use load expectations to compute TTI instead of using loading
metric. This would be cleaner and remove dependency on loading metric.

Bug: chromium:796109 
Change-Id: I7edf5aa0b9f32082539df7114aeaf8014592852d
Reviewed-on: https://chromium-review.googlesource.com/937701
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Deepanjan Roy <dproy@chromium.org>

[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/extras/chrome/event_finder_utils.html
[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/metrics/system_health/loading_metric.html
[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/metrics/system_health/power_metric.html
[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/metrics/system_health/expected_queueing_time_metric_test.html
[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/metrics/v8/runtime_stats_metric.html
[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/importer/find_load_expectations.html
[modify] https://crrev.com/f73167a6894a911709d1d6c88f1bc97cb133de33/tracing/tracing/extras/chrome/estimated_input_latency.html

Comment 12 by npm@chromium.org, Jun 27 2018

Is this Fixed now?

Comment 13 by dproy@chromium.org, Jun 27 2018

Status: Fixed (was: Started)
This is done thanks to mythria. 

Sign in to add a comment