rnephew@: telemetry_perf_unittests started failing. https://chromium.googlesource.com/chromium/src/+/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7 says I should contact you if there is an issue. Could you take a look?

It looks like 'Speedometer2' is failing. I think my converter script for expectations missed it because of some inheritance issues. Unimportant though, the fix is simple.

All that needs to be done is add the expectation here:
https://cs.chromium.org/chromium/src/tools/perf/expectations.config?q=expectations.config&sq=package:chromium&l=211
'
# Benchmark: Speedometer2
crbug.com/792495 [ Linux ] speedometer2/Speedometer2 [ Skip ] 
'

My desktop is packed up and being moved today, so I'm unable to land this change. I could check it out on my laptop, but that might take longer than someone else just doing it and I review the cl. Can someone help? Thanks.

I will disable this test

Hmhh, actually the failing test is speedometer2-future

So the real bug is benchmark_smoke_unittest hasn't been hooked with expectations.config file yet

Thats an easy fix. Should be the same as this cl:
https://chromium-review.googlesource.com/c/chromium/src/+/832381

Still failing on the latest build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/69068.

Are we expecting this to recover after a catapult roll?

CL for the fix is in the commit queue right now. The CL is Chromium-side only, so no Catapult roll should be required: https://chromium-review.googlesource.com/c/chromium/src/+/834449

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378b8d3cafcf8e3cac8e9ed98d496fc2a1ac9db3

commit 378b8d3cafcf8e3cac8e9ed98d496fc2a1ac9db3
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Dec 19 21:23:18 2017

Makes benchmark_smoke_unittest pull in expectations.config

Without this, the unit test expects benchmarks to pass that are in fact
failing.

Bug:  796105 
Change-Id: I83806d5df5e0c70677eed3ae79b74f393096c03d
Reviewed-on: https://chromium-review.googlesource.com/834449
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525145}
[modify] https://crrev.com/378b8d3cafcf8e3cac8e9ed98d496fc2a1ac9db3/tools/perf/benchmarks/benchmark_smoke_unittest.py

This is fixed. The build is green now!