New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796079 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Regression: Unable to select cells on google sheets and page jumps on scrolling

Project Member Reported by kkaluri@chromium.org, Dec 19 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/59620135abb6dc7802569b3a8a7214d19657c2b1

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=795252


Thank you!
 
 

Comment 1 by junov@chromium.org, Jan 8 2018

Labels: -Pri-0 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fd5440ed9a178828fcc752bc1b180c3ad715086

commit 1fd5440ed9a178828fcc752bc1b180c3ad715086
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jan 10 21:14:06 2018

Add test for SyncToken updates in 2D canvas GpuMemoryBuffer code path

This change adds a test and also re-arranges the fix from previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/832350

BUG= 796079 , 795635 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iff30eeebaf72bb4dc34be0dc7bd4afc3fc2e9ced
Reviewed-on: https://chromium-review.googlesource.com/836752
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528423}
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/graphics/CanvasResource.h
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a08442c76baf9fe44415a14aee1a2e7a95ae582

commit 3a08442c76baf9fe44415a14aee1a2e7a95ae582
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Wed Jan 10 23:03:21 2018

[jumbo] rename duplicate FakePlatformSupport class

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/836752
in order to un-break jumbo builds.

TBR=junov@chromium.org
BUG= 796079 , 795635 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I605b8bb07357f6aa478692ffdb6b12454b891267
Reviewed-on: https://chromium-review.googlesource.com/860923
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#528460}
[modify] https://crrev.com/3a08442c76baf9fe44415a14aee1a2e7a95ae582/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp

Comment 4 by junov@chromium.org, Jan 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment