VisibleURLTestCase is flaky on device |
|||
Issue descriptionThe test suite has failed 4 times on the last 6 runs on iPhone 11 devices. It also failed on iPad devices. https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/1670 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone11-device-x64/builds/1672 Marking them as flaky. They should be re-enabled. Assigning to Eugene for triage if needed.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00525197309fa3b4b38f93f0120520c45b2e508d commit 00525197309fa3b4b38f93f0120520c45b2e508d Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Dec 19 10:08:51 2017 Mark VisibleURLTestCase as flaky This CL marks the tests of the test case as flaky. Only testDoubleBackJSNavigation wasn't found flaky. Bug: 796070 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id6612a886ba03ee175b27d3cc3588a937d8bbba6 Reviewed-on: https://chromium-review.googlesource.com/832460 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#524989} [modify] https://crrev.com/00525197309fa3b4b38f93f0120520c45b2e508d/ios/chrome/browser/web/visible_url_egtest.mm
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2ddfee19c1b6052a8e3be4734931de44e823396 commit c2ddfee19c1b6052a8e3be4734931de44e823396 Author: Eugene But <eugenebut@google.com> Date: Wed Dec 20 00:50:04 2017 Speculative fix for VisibleURLTestCase tests. PurgeCachedWebViewPages() kills the page and before interacting with the browser it may be useful to wait until the page is actually loaded again before pausing the server. Bug: 796070 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5cc616bfeb415095e27e642e0df9ff776c7df5e0 Reviewed-on: https://chromium-review.googlesource.com/835356 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#525195} [modify] https://crrev.com/c2ddfee19c1b6052a8e3be4734931de44e823396/ios/chrome/browser/web/visible_url_egtest.mm
,
Jan 16 2018
Is this now fixed?
,
Jan 16 2018
I did not see any recent failures on Flaky bots. Will enable the tests and see how that goes.
,
Jan 16 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0c08d4a43b7daa724955f2ae20d95bf596737607 commit 0c08d4a43b7daa724955f2ae20d95bf596737607 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 16 21:48:43 2018
,
Jan 16 2018
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9454045338b7103b19caf58e7b42bb2b726ab8b5 commit 9454045338b7103b19caf58e7b42bb2b726ab8b5 Author: Eugene But <eugenebut@google.com> Date: Tue Jan 16 22:45:11 2018 Enabled VisibleURLTestCase tests on device. No recent failures on device bots. Speculative fix was landed earlier: https://chromium-review.googlesource.com/835356 Bug: 796070 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I975ebb6dcfc81f9cb9032804f5389a656a4351c4 Reviewed-on: https://chromium-review.googlesource.com/868324 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#529512} [modify] https://crrev.com/9454045338b7103b19caf58e7b42bb2b726ab8b5/ios/chrome/browser/web/visible_url_egtest.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by sdefresne@chromium.org
, Dec 19 2017