New issue
Advanced search Search tips

Issue 796064 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

CreditCardSaveManagerTest are failing on beta bots

Project Member Reported by gambard@chromium.org, Dec 19 2017

Issue description

The CreditCardSaveManagerTest components unit tests are failing on the beta builder.
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/beta-simulator/builds/3280

The tests were failing at branch point (Dec 1) and the CL to disable them was landed after branch point. We have the broken version in our M64 checkout.

The bots are currently red and we should fix it.

sebsg@: Should we disable them or is there a fix we can/should cherry-pick to M64?
 
Owner: se...@chromium.org
Assigning to sebsg@, do you have any clue?
ping, still failing on beta.
Should this block release?

Comment 3 by se...@chromium.org, Jan 3 2018

Status: Started (was: Assigned)
Hi Sorry for the delay, I was on vacation.

I don't think this should block anything because it was only test related. 

I started the process to merge in 64

Thanks
Thanks!
Is there any update here?

Comment 6 by se...@chromium.org, Jan 8 2018

Status: Fixed (was: Started)
https://chromium-review.googlesource.com/c/chromium/src/+/852394 landed in M64 this morning.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.

Comment 8 by se...@chromium.org, Jan 8 2018

Labels: -Merge-TBD
It landed in M64

Sign in to add a comment