New issue
Advanced search Search tips

Issue 796045 link

Starred by 1 user
Status: Fixed
Owner:
yawano@chromium.org
Closed: Jan 2018
Cc:
dtseng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Spoken feedback doesn't work if it's enabled with focus highlight

Project Member Reported by yawano@chromium.org, Dec 19 2017 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Enable focus highlight in accessibility setting
(2) Press Ctrl+Alt+Z to enable spoken feedback
(3) Open any Android application. Spoken feedback doesn't work.

What is the expected result?
Spoken feedback works.

What happens instead?
Spoken feedback doesn't work even if focus highlight is disabled after step 3.

Additional info
This is caused because filter type is updated only when connection is ready. In this test case, filter type is set to FOCUS and it's not updated. This is related to TODO around line 226 in arc_accessibility_helper_bridge.cc.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9be31c50d3f116bd9aef9a8032a4f6fc214f1737

commit 9be31c50d3f116bd9aef9a8032a4f6fc214f1737
Author: Yuki Awano <yawano@chromium.org>
Date: Thu Jan 18 01:36:00 2018

Change ArcAccessibilityHelperBridge to handle preference change

This CL does following things with preference change:

- Update filter type
- Add/remove activation observer
- Update touch exploration pass through of current active window

Bug:  796045 
Test: ArcAccessibilityHelperBridgeBrowserTest.PreferenceChange
Change-Id: I110ebe4fdd581b8528460e430da61e8e87137ef0
Reviewed-on: https://chromium-review.googlesource.com/833829
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530003}
[modify] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
[add] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/chrome/test/BUILD.gn
[modify] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/components/arc/BUILD.gn
[add] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/components/arc/test/fake_accessibility_helper_instance.cc
[add] https://crrev.com/9be31c50d3f116bd9aef9a8032a4f6fc214f1737/components/arc/test/fake_accessibility_helper_instance.h

Comment 2 by yawano@chromium.org, Jan 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment