New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796029 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add animation to Notification inline settings

Project Member Reported by tetsui@chromium.org, Dec 19 2017

Issue description

According to UX mock, inline settings should have transition animation that is aligned to Android's one.

https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCFtDtB7WO4l5T_XIlIkONmqwMSJbxAVNpw
 
2017-12-18.png
28.8 KB View Download

Comment 1 by tetsui@chromium.org, Dec 19 2017

Cc: sgabr...@chromium.org

Comment 2 by tetsui@chromium.org, Jan 26 2018

Cc: megumihattori@google.com
Cc: -megumihattori@google.com tetsui@chromium.org
Owner: megumihattori@google.com
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b4ab8eb4c45c4719babfcf01226eff6b837c21f

commit 4b4ab8eb4c45c4719babfcf01226eff6b837c21f
Author: Megumi Hattori <megumihattori@google.com>
Date: Wed Feb 07 02:42:44 2018

Add animation and remove actions row when inline settings appears.

While the inline settings is appearing right after the settings button at the top of the notification is clicked, the notification is changing the color from white to light gray as a ripple circle like ink drop expands. At the same time, the actions row which has inline action buttons or an inline textfield is hidden.

When the inline settings is closed, the animation is hidden, and the action rows appeares.


Bug= 796029 

Change-Id: I0d9e1a98f6f83c120d18f274d8fa3910170489ef
Reviewed-on: https://chromium-review.googlesource.com/903622
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#534890}
[modify] https://crrev.com/4b4ab8eb4c45c4719babfcf01226eff6b837c21f/ui/message_center/views/message_view.cc
[modify] https://crrev.com/4b4ab8eb4c45c4719babfcf01226eff6b837c21f/ui/message_center/views/message_view.h
[modify] https://crrev.com/4b4ab8eb4c45c4719babfcf01226eff6b837c21f/ui/message_center/views/notification_control_buttons_view.cc
[modify] https://crrev.com/4b4ab8eb4c45c4719babfcf01226eff6b837c21f/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/4b4ab8eb4c45c4719babfcf01226eff6b837c21f/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/4b4ab8eb4c45c4719babfcf01226eff6b837c21f/ui/message_center/views/notification_view_md_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment