Jimmy told me before drop API is not used at all. audio_AlsaAPI.drop tests can be removed completely.

Yes it is not used in CRAS.
We can disable it completely, or disable it on the boards that is known to fail.
Either way is fine.

Can we remove the test? It is confusing for partners to keep a unused test.

But it will be better if they can implement it right and pass the test, since it is part of ALSA API.
If we keep allowing partner not implementing this API correctly, it will limit our usage in the future.

I don't know the nature of drop API so I cannot say it for sure. In general I believe adding a test for API we are not using is like dead weight for us and partners. The test will not be maintained and always failing (like this one). Partners will need to add code that is unused. We can always add the test back if we start to enforce is in the future.

I can see either side of this. I'd lean towards enforcing that this test pass. It feels like everytime we want to call a standard alsa API that we haven't exercised, several boards fail to implement it and it greatly impedes adding new features.

When we switched from drop to flush it took a long time to catch all the issues with the faulty alsa implementations.

 Issue 796016  has been merged into this issue.

I've disabled the test for boards that don't support it, and left it enabled for those that do.