Do we need to align with [1]? [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AlgdRmovICc At least, I think we need to add two READMEs as follows. - Browser-side: content/browser/service_worker - Renderer-side: third_party/WebKit/modules/serviceworkers
Good idea. I made one in WebKit/common/service_worker. We can add similar ones in the others. I was hoping to have a real README explaining the architecture as well.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034 commit 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Jul 12 08:46:41 2018 Add service worker README.md. Bug: 795989 Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d Reviewed-on: https://chromium-review.googlesource.com/1134718 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574507} [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/content/browser/service_worker/README.md [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/content/common/service_worker/README.md [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/third_party/blink/common/service_worker/README.md [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/third_party/blink/public/common/service_worker/README.md [modify] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/third_party/blink/public/mojom/service_worker/README.md [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/third_party/blink/public/platform/modules/service_worker/README.md [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/third_party/blink/public/web/modules/service_worker/README.md [add] https://crrev.com/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034/third_party/blink/renderer/modules/service_worker/README.md
I think we can call this fixed and link documentation commits to it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c092e144b56732092d6963711959f21069eab6a9 commit c092e144b56732092d6963711959f21069eab6a9 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Aug 20 07:32:21 2018 service worker: Add documentation about where Mojo interfaces live. Bug: 795989 Change-Id: Ieb5267a87b43f14a6ae3f3bc29b14402afd2e3ab Reviewed-on: https://chromium-review.googlesource.com/1166277 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584376} [modify] https://crrev.com/c092e144b56732092d6963711959f21069eab6a9/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/c092e144b56732092d6963711959f21069eab6a9/content/common/service_worker/service_worker_container.mojom [modify] https://crrev.com/c092e144b56732092d6963711959f21069eab6a9/content/common/service_worker/service_worker_provider.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/163f8961f8a71aede90d0c13eb5d1ffddbcceb8e commit 163f8961f8a71aede90d0c13eb5d1ffddbcceb8e Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Aug 27 03:45:02 2018 service worker: Add documentation about UseCounter to README. Bug: 795989 Change-Id: I8b275dfeaab7f4f08f2a70130b74f98a344bed72 Reviewed-on: https://chromium-review.googlesource.com/1188728 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586190} [modify] https://crrev.com/163f8961f8a71aede90d0c13eb5d1ffddbcceb8e/content/browser/service_worker/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea commit 504ec5fc0b9292c72e30692e95ab67f1e28ad7ea Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Aug 30 01:22:13 2018 service worker: Add storage section to README. Thanks to Joshua Bell for explaining Quota Manager to me. Bug: 795989 Change-Id: I9a26a93f52687761419dc387e37d1baccf04671e Reviewed-on: https://chromium-review.googlesource.com/1194805 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#587361} [modify] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/content/browser/service_worker/README.md
Comment 1 by shimazu@chromium.org
, Dec 19 2017