media router extension: change how it use the mojo namespace. |
|||
Issue description
Currently the media router extension creates a mojo object to load mojo JS bindings. However, it later resets the contents of this mojo object to the result of chrome.mojoPrivate.requireAsync('media_router_bindings'):
https://cs.corp.google.com/piper///depot/google3/third_party/chrome_media_router/interface_data/mojo.js?rcl=162517803&l=41
In order to keep things working, the mojo JS bindings internally cannot refer to "mojo" directly. We also had to export a few mojo internal classes in media_router_bindings.js.
It would be nice if we can change how the media router extension work to avoid these hacks.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5862ffc3f7ca6bf9c1287b80ac978163370da554 commit 5862ffc3f7ca6bf9c1287b80ac978163370da554 Author: Yuzhu Shen <yzshen@chromium.org> Date: Tue Dec 19 03:22:00 2017 Mojo JS bindings: update some TODOs. BUG=795977 Change-Id: Ia696f7158d19f045cce61c2775dd43492e9611ba Reviewed-on: https://chromium-review.googlesource.com/833101 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524929} [modify] https://crrev.com/5862ffc3f7ca6bf9c1287b80ac978163370da554/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/5862ffc3f7ca6bf9c1287b80ac978163370da554/mojo/public/tools/bindings/generators/mojom_js_generator.py
,
Jan 15
Hello Mark, I have assigned this ticket to you as an owner of //depot/google3/third_party/chrome_media_router. Could you please forward it to the appropriate media team members? The described issue will no longer exist if the media router extension is converted to new JS bindings. Thanks!
,
Jan 15
,
Jan 15
Sure. Is there some documentation on the migration/changes you'd like to see? |
|||
►
Sign in to add a comment |
|||
Comment 1 by yzshen@chromium.org
, Dec 19 2017Components: Internals>Mojo>Bindings