Chrome Version: 65.0.3299.0 (Developer Build) (32-bit) OS: Windows 10 1. Go to a page that hangs (e.g. chrome://hang) and wait 2. Click "Exit page" on the dialog that pops up 3. This DCHECK triggers: https://cs.chromium.org/chromium/src/chrome/browser/hang_monitor/hang_crash_dump_win.cc?type=cs&l=40 This happens if a real website hangs too. Attaching a screenshot of the full stack.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6146c51e304193e78ea21d3f2c95af4e507d52f commit c6146c51e304193e78ea21d3f2c95af4e507d52f Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Dec 20 22:48:15 2017 Remove Crash Keys sent to the renderer for hung renderers. Now that we've addressed the crashes we can remove any debugging code we added. BUG=615090, 795955 Change-Id: I1f0a0fdd895f4c7d1b5ac8d2b7b1f464a91e8e47 Reviewed-on: https://chromium-review.googlesource.com/834390 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525500} [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/hang_monitor/hang_crash_dump_win.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/hang_monitor/hang_crash_dump_win.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/browser.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/browser.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/hung_plugin_tab_helper.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/hung_renderer_browsertest.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/tab_dialogs.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/views/hung_renderer_view.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/views/hung_renderer_view.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/views/tab_dialogs_views.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome/browser/ui/views/tab_dialogs_views.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome_elf/chrome_elf_x64.def [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/chrome_elf/chrome_elf_x86.def [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/crash/content/app/breakpad_win.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/crash/content/app/crash_export_stubs.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/crash/content/app/crash_export_thunks.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/crash/content/app/crash_export_thunks.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/crash/content/app/crashpad.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/crash/content/app/crashpad_win.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/web_contents_delegate_android/web_contents_delegate_android.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/components/web_contents_delegate_android/web_contents_delegate_android.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/input_router_client.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/legacy_input_router_impl.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/legacy_input_router_impl_perftest.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/mock_input_router_client.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/input/mock_input_router_client.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/public/browser/BUILD.gn [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/public/browser/web_contents_delegate.h [delete] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/content/public/browser/web_contents_unresponsive_state.cc [delete] https://crrev.com/fa911adb4d24f2f76e21df2e84ea1549b08fab6b/content/public/browser/web_contents_unresponsive_state.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/shell/browser/shell.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/content/shell/browser/shell.h [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/extensions/browser/guest_view/web_view/web_view_guest.cc [modify] https://crrev.com/c6146c51e304193e78ea21d3f2c95af4e507d52f/extensions/browser/guest_view/web_view/web_view_guest.h
Comment 1 by dtapu...@chromium.org
, Dec 19 2017Status: Assigned (was: Untriaged)