New issue
Advanced search Search tips

Issue 795931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Multiple concurrent auth attempts can break auth

Project Member Reported by jdufault@chromium.org, Dec 18 2017

Issue description

(This needs to get merged to 64).
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 18 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-64
Adding M-64 label to assist with search queries.

Not enough info here.  Is this a M64 regression?  Customer impact?  When was this introduced?  This appears to be a fairly large update.
This is a regression with the new lock screen implementation. If a user types a password on the lock screen twice in quick succession, they will be unable to unlock the device and forced to sign out.

The patch has been stable since landing on 65, so I think the merge risk is relatively low for an important fix.
Looks to be a rather large update from the CL....   Assume this potentially spans all boards?
The patch has landed on M65 for a while. And yes, it happens across the boards.

It is an important fix and think we should merget it M64. It is easy to trigger (e.g. hitting enter twice after entering the password). And when it happens, we would see strange things like issue 795822 where correct password does not unlock the device, or chrome crashes after unlocking.
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 4 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc5265b4d714c28c7273e1e77da577845d476b0a

commit cc5265b4d714c28c7273e1e77da577845d476b0a
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Jan 04 22:49:22 2018

cros: Dedup concurrent auth attempts on views-based lock screen.

If there are concurrent attempts (ie, spamming spacebar and enter) lock
would get into a bad state. Prevent concurrent attempts.

TBR=jdufault@google.com

(cherry picked from commit b7a2d848a0cb3db536debc26d7d5540196aca27d)

Bug:  795931 
Change-Id: I4e40368fc8daa1d6ba3c47d4d181a0331b29d2a2
Reviewed-on: https://chromium-review.googlesource.com/688734
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521111}
Reviewed-on: https://chromium-review.googlesource.com/850855
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#410}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/login_screen_controller.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/login_screen_controller.h
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/login_screen_controller_unittest.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/mock_login_screen_client.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/ui/login_password_view.h
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/ash/login/ui/login_password_view_test.cc
[modify] https://crrev.com/cc5265b4d714c28c7273e1e77da577845d476b0a/testing/buildbot/filters/ash_unittests_mash.filter

Sign in to add a comment