New issue
Advanced search Search tips

Issue 795917 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Body.idl has Exposed=ServiceWorker

Project Member Reported by jsb...@chromium.org, Dec 18 2017

Issue description

modules/fetch/Body.idl has:

[
    ActiveScriptWrappable,
    Exposed=ServiceWorker,
    NoInterfaceObject
] interface Body { ... }


Spec https://fetch.spec.whatwg.org/#body has:

[NoInterfaceObject, Exposed=(Window,Worker)]
interface Body { ... }

Given that this is a mixin (via [NoInterfaceObject]) it's unclear what [Exposed] even means here, but it shouldn't be just ServiceWorker.

This is somewhat moot as WebIDL has grown real "mixin" support, so this will change in the spec soon.

I don't think this manifests as a bug anywhere, so it's just a matter of code correctness.
 
Cc: -yhirano@chromium.org
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
It's now 

interface mixin Body {
  readonly attribute ReadableStream? body;
  readonly attribute boolean bodyUsed;
  [NewObject] Promise<ArrayBuffer> arrayBuffer();
  [NewObject] Promise<Blob> blob();
  [NewObject] Promise<FormData> formData();
  [NewObject] Promise<any> json();
  [NewObject] Promise<USVString> text();
};

in the spec (see https://github.com/w3c/web-platform-tests/pull/8701).
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c92a799d24ff901b7338ca9d0e7a704fafc186b

commit 2c92a799d24ff901b7338ca9d0e7a704fafc186b
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 05 08:08:18 2018

Remove Exposed=ServiceWorker from Body IDL definition

Body is an interface mixin which is not supported by the Blink IDL
processor, but it doesn't make sense to have Exposed=ServiceWorker
anyway.

Bug:  795917 
Change-Id: I3d90a33785e44616a52b22603c3b29d97ec21ee6
Reviewed-on: https://chromium-review.googlesource.com/851696
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527241}
[modify] https://crrev.com/2c92a799d24ff901b7338ca9d0e7a704fafc186b/third_party/WebKit/Source/core/fetch/Body.idl

Status: Fixed (was: Assigned)

Sign in to add a comment