New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795900 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ICE negotiation failing with ICE-lite implementation

Project Member Reported by deadbeef@chromium.org, Dec 18 2017

Issue description

Chrome Version: (64.0.3282.24)
OS: (Any)

What steps will reproduce the problem?
(1) Connect from Chrome to an ICE-lite endpoint. For example, https://apollo-lt.bbcollab.com/guest/dbb7f65a323b4a5bb5694652a1b09d88
(2) After a while watching a spinning circle, connection attempt fails.  Upon further investigation, it appears the ICE negotiation is failing.

What is the expected result?

User joins conference room after successful ICE negotiation.
Since the Collaborate MCU uses an ICE-lite implementation, according to RFC5245 Chrome MUST take the ICE-CONTROLLING role (section 5.2), and should nominate a single candidate pair using the USE-CANDIDATE attribute (section 8.1.1).

What happens instead?

Chrome is advertising itself as ICE-CONTROLLED in STUN requests, and never nominating a candidate pair.  ICE negotiation fails after a timeout.

Corresponding WebRTC bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=8531

And fix: https://webrtc-review.googlesource.com/26780

This is expected to affect all ICE-lite implementations, so it has a high severity. We'd like it to be merged to M64 if possible. Unfortunately I couldn't find statistics indicating how many sites are ICE-lite, but it's expected to be non-trivial.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 18 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add affected OSs.
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Is this well tested in Canary and is this a fairly safe merge overall? Since M64 is already in Beta, we'd like to ensure we take only critical or high severity bugs that are well tested and safe. 
Yes, has been verified in Canary, and it's a very safe change. Fix made on Dec 4 and no new issues reported, and it's only really 10 lines of code that addresses a corner case.
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge for M64. Branch:3282
Owner: deadbeef@chromium.org
Status: Assigned (was: Untriaged)
Cc: anatolid@chromium.org
deadbeef@, reminder to please merge CL to M64 branch 3282.
Labels: -Merge-Approved-64 Merge-Merged
Status: Fixed (was: Assigned)
Already done here, just forgot to update bug: https://webrtc-review.googlesource.com/c/src/+/34980

Sign in to add a comment