ICE negotiation failing with ICE-lite implementation |
||||||
Issue descriptionChrome Version: (64.0.3282.24) OS: (Any) What steps will reproduce the problem? (1) Connect from Chrome to an ICE-lite endpoint. For example, https://apollo-lt.bbcollab.com/guest/dbb7f65a323b4a5bb5694652a1b09d88 (2) After a while watching a spinning circle, connection attempt fails. Upon further investigation, it appears the ICE negotiation is failing. What is the expected result? User joins conference room after successful ICE negotiation. Since the Collaborate MCU uses an ICE-lite implementation, according to RFC5245 Chrome MUST take the ICE-CONTROLLING role (section 5.2), and should nominate a single candidate pair using the USE-CANDIDATE attribute (section 8.1.1). What happens instead? Chrome is advertising itself as ICE-CONTROLLED in STUN requests, and never nominating a candidate pair. ICE negotiation fails after a timeout. Corresponding WebRTC bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=8531 And fix: https://webrtc-review.googlesource.com/26780 This is expected to affect all ICE-lite implementations, so it has a high severity. We'd like it to be merged to M64 if possible. Unfortunately I couldn't find statistics indicating how many sites are ICE-lite, but it's expected to be non-trivial.
,
Dec 18 2017
Please add affected OSs.
,
Dec 18 2017
,
Dec 18 2017
Is this well tested in Canary and is this a fairly safe merge overall? Since M64 is already in Beta, we'd like to ensure we take only critical or high severity bugs that are well tested and safe.
,
Dec 19 2017
Yes, has been verified in Canary, and it's a very safe change. Fix made on Dec 4 and no new issues reported, and it's only really 10 lines of code that addresses a corner case.
,
Dec 19 2017
Approving merge for M64. Branch:3282
,
Dec 19 2017
,
Dec 19 2017
,
Jan 2 2018
deadbeef@, reminder to please merge CL to M64 branch 3282.
,
Jan 2 2018
Already done here, just forgot to update bug: https://webrtc-review.googlesource.com/c/src/+/34980 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Dec 18 2017