New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795898 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 690513



Sign in to add a comment

apmanager: move back from AOSP to platform2

Project Member Reported by vapier@chromium.org, Dec 18 2017

Issue description

background can be found in issue 690513.  this tracks just apmanager work.
 

Comment 1 Deleted

Comment 2 by vapier@chromium.org, Dec 19 2017

Cc: z...@chromium.org
i've posted the rewrite here:
https://chromium.googlesource.com/chromiumos/platform2/+/sandbox/vapier/apmanager

was pretty easy as there haven't been that many commits.  i filtered out:
- Android specific files (e.g. NOTICE and apmanager.rc)
- the BSD->Apache relicense since it had no conflicts

i didn't try removing all the __BRILLO__ defines as they're too integrated with other CLs.  so if we want to scrub those, we'll have to do it in a follow up commit.

Comment 4 by vapier@chromium.org, May 30 2018

Cc: hidehiko@chromium.org
i'm "just" waiting on cursory reviews of my rewrite/merge work.  you feel like doing it Hidehiko ? :)
Owner: vapier@chromium.org
Status: Started (was: Available)
now that R69 has branched, i pulled in the last few CLs that were merged to the AOSP copy, then pushed it into platform2.  CLs are in flight to drop the rpeo from the manifest.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d766b1e1577838e6ace65b72719c4503b536b217

commit d766b1e1577838e6ace65b72719c4503b536b217
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 07:46:37 2018

apmanager: build out of platform2

BUG= chromium:795898 
TEST=precq passes

Change-Id: Ia2745bec8974a3d03a6c441f2aaae3223db79666
Reviewed-on: https://chromium-review.googlesource.com/834229
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d766b1e1577838e6ace65b72719c4503b536b217/chromeos-base/apmanager/apmanager-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/812a382e4a08ec63054f56db570f400e09eebc6a

commit 812a382e4a08ec63054f56db570f400e09eebc6a
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 11:11:32 2018

apmanager: fix gyplint warnings

BUG= chromium:795898 
TEST=gyplint passes

Change-Id: I472dff9865055e8fb029b83b40d0d6b9d1e44f7c
Reviewed-on: https://chromium-review.googlesource.com/1147714
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/812a382e4a08ec63054f56db570f400e09eebc6a/apmanager/apmanager.gyp

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/5f5cfe026de37e1223a528be25376bf102aba18b

commit 5f5cfe026de37e1223a528be25376bf102aba18b
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 19:44:12 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/89a3313db35391ce8bf2935336692d830d09f2a3

commit 89a3313db35391ce8bf2935336692d830d09f2a3
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 19:44:22 2018

apmanager: move back to platform2

BUG= chromium:795898 
TEST=precq passes

Change-Id: Ifb7085a152881cd83df6e82c50238c7cb965f093
Reviewed-on: https://chromium-review.googlesource.com/1147702
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/89a3313db35391ce8bf2935336692d830d09f2a3/full.xml

Sign in to add a comment