New issue
Advanced search Search tips

Issue 795887 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 788213



Sign in to add a comment

Write integration and functional tests at top level

Project Member Reported by jclinton@chromium.org, Dec 18 2017

Issue description

From the Hardening Mosys design doc:
https://docs.google.com/document/d/1MkBUhp6KURhB2HArB7QYcrMpU8z1PQgknU-hx8c4K2k/edit

Mosys currently has no unit, functional, or integration tests. This feature bug will track implementing functional tests at the top level and an integration test in Autotest/Tast.

Unit tests will be required for code changes going forward.

 
Cc: nsanders@chromium.org
A functional testing framework has been added to Mosys in https://chromium-review.googlesource.com/c/chromiumos/platform/mosys/+/1175110 . The last step is to add it to src_test. The src_compile step will also need a conditional:

if use test;
  //enable dummy and stub compilation;
fi

This works because the UnitTest phase does a new compile pass and doesn't install the resulting binaries.

This is also the last bug under the Hardening Mosys umbrella still open so, we're close—at least as far as that design was concerned.

Owner: shapiroc@chromium.org
Status: Assigned (was: Available)
The change had to be rolled back for causing platform reboots in  issue 878145 . This was due to a bug in the change that caused SMBIOS probes to be run on ARM devices tripping the ATF fault logic.

Charles has said that he's going to work on testing/verification/audits as a larger project.

Sign in to add a comment