New issue
Advanced search Search tips

Issue 795884 link

Starred by 0 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Rework layering of targets / components inside of gpu/

Project Member Reported by piman@chromium.org, Dec 18 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d

commit 95431c6e2625cbb52d1a72509e7ad0daeb2ba50d
Author: Antoine Labour <piman@chromium.org>
Date: Tue Dec 19 17:02:28 2017

gpu: split gles2-specific files into separate source_sets

They all still go into a single component, but that is starting to
clarify dependencies. This (mostly) doesn't include code changes,
beyond removing useless/harmful headers.

Some pieces are not into their final target, because they require code
changes/refactoring, which will go into future CLs.

Bug: 795884
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I69effc2af24d0363392a68b4ef3b2c3ab097c876
Reviewed-on: https://chromium-review.googlesource.com/833178
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525064}
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/components/viz/common/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/content/browser/compositor/software_browser_compositor_output_surface.cc
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/command_buffer/client/transfer_buffer.h
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/command_buffer/common/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/command_buffer/common/mailbox_holder.h
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/command_buffer/service/transfer_buffer_manager.cc
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/ipc/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/media/video/BUILD.gn
[modify] https://crrev.com/95431c6e2625cbb52d1a72509e7ad0daeb2ba50d/ppapi/proxy/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feab23938bafe07fa1c8bec8d85d1df30976b0a3

commit feab23938bafe07fa1c8bec8d85d1df30976b0a3
Author: Antoine Labour <piman@chromium.org>
Date: Thu Dec 21 22:39:34 2017

gpu: Split non-GLES2 specifics from :gles2_utils into :common

Move ContextType, ColorSpace, ContextCreationAttribHelper out of
gles2_cmd_utils.* into context_creation_attribs.*, and out of the gpu::gles2
namespace into the gpu namespace.
Also rename ContextCreationAttribHelper to ContextCreationAttribs since it isn't
a helper anymore after crrev.com/c/834771 and this CL touches all references
anyway.

Bug: 795884
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifcea78eb74c06cdc70f1a3d4d53f9a1edf0b8885
Reviewed-on: https://chromium-review.googlesource.com/837706
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525835}
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/android_webview/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/android_webview/browser/aw_render_thread_context_provider.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/cc/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/cc/paint/transfer_cache_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/cc/test/DEPS
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/components/viz/common/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/components/viz/common/gl_helper_benchmark.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/components/viz/common/gl_helper_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/components/viz/common/gpu/in_process_context_provider.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/components/viz/common/gpu/in_process_context_provider.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/components/viz/common/yuv_readback_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/common/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/public/browser/android/compositor.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/pepper/pepper_video_encoder_host.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/pepper/ppb_graphics_3d_impl.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/pepper/ppb_graphics_3d_impl.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/pepper/resource_creation_impl.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/pepper/resource_creation_impl.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/content/test/layouttest_support.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/common/BUILD.gn
[add] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/common/context_creation_attribs.cc
[add] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/common/context_creation_attribs.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/common/gles2_cmd_utils.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/common/gles2_cmd_utils.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder_mock.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder_mock.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/raster_decoder.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/service_utils.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/service/test_helper.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/decoder_perftest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/es3_misc_functions_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_apply_screen_space_antialiasing_CHROMIUM_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_ext_blend_func_extended_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_ext_window_rectangles_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_map_buffer_range_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_object_bindings_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_program_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_request_extension_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_set_aggressively_free_resources_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/command_buffer/tests/gl_virtual_contexts_ext_window_rectangles_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/gles2_conform_support/egl/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/gles2_conform_support/egl/context.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/client/gpu_in_process_context_tests.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/gl_in_process_context.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/gl_in_process_context.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/gpu/ipc/service/gpu_channel_unittest.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/proxy/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/proxy/ppb_graphics_3d_proxy.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/proxy/ppb_graphics_3d_proxy.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/proxy/resource_creation_proxy.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/proxy/resource_creation_proxy.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ppapi/thunk/resource_creation_api.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/services/ui/public/cpp/gpu/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/services/ui/public/cpp/gpu/context_provider_command_buffer.h
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ui/compositor/BUILD.gn
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ui/compositor/test/in_process_context_provider.cc
[modify] https://crrev.com/feab23938bafe07fa1c8bec8d85d1df30976b0a3/ui/compositor/test/in_process_context_provider.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40b0ca4848baaa1ff1c12632703747bf389260b0

commit 40b0ca4848baaa1ff1c12632703747bf389260b0
Author: Antoine Labour <piman@chromium.org>
Date: Wed Jan 03 22:11:45 2018

Move MailboxManager and TextureBase out of gles2

Also move MailboxManager::Create into a free function in a separate header.

Bug: 795884
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie8e9d87d1e3b727f7e5cba1f2d78551366968c51
Reviewed-on: https://chromium-review.googlesource.com/849273
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526834}
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/gles2_cmd_decoder.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/mailbox_manager.h
[rename] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/mailbox_manager_factory.cc
[add] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/mailbox_manager_factory.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/mailbox_manager_impl.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/mailbox_manager_impl.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/mailbox_manager_sync.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/raster_decoder.h
[add] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/texture_base.cc
[add] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/texture_base.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/command_buffer/tests/gl_manager.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/gpu_in_process_thread_service.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/gpu_in_process_thread_service.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/media/gpu/gles2_decoder_helper.cc
[modify] https://crrev.com/40b0ca4848baaa1ff1c12632703747bf389260b0/media/gpu/ipc/service/gpu_video_decode_accelerator.cc

Comment 4 by piman@chromium.org, Jan 3 2018

I will take a small detour and make gpu/ipc/services a separate component, so that we don't have to disentangle all the service-side dependencies (injection of gles2 and raster) just yet, to avoid roundabout changes before allowing the separation of gles2 and raster components. We can merge it back into //gpu later if we desire.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa

commit ec6176ba735289ed0ae547769bf6d5a0d0efdaaa
Author: Antoine Labour <piman@chromium.org>
Date: Fri Jan 05 01:28:43 2018

Move //gpu/ipc:command_buffer into //gpu/ipc:gl_in_process_context

Because InProcessCommandBuffer needs gles2 things, we want to move it
out of //gpu. It could be its own component, but gl_in_process_context
already is one, and is used in the same places, so merge into that one.

Bug: 795884
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id7279e04e5f9bee1dea1decd58735585bc776681
Reviewed-on: https://chromium-review.googlesource.com/849414
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527184}
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/components/viz/service/BUILD.gn
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/components/viz/service/main/BUILD.gn
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/content/test/BUILD.gn
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/gpu/BUILD.gn
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/gpu/command_buffer/service/mailbox_manager_factory.h
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/gpu/ipc/BUILD.gn
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/gpu/ipc/gpu_in_process_thread_service.h
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/ec6176ba735289ed0ae547769bf6d5a0d0efdaaa/gpu/ipc/service/image_transport_surface.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f

commit 5f0b26759cdd6169ebd9fc2b247bd1aa623e312f
Author: Antoine Labour <piman@chromium.org>
Date: Sat Jan 06 02:31:49 2018

Make //gpu/ipc/service a separate component

This depends on gles2 things, and inverting the relationship is quite
involved, so make it a separate component so that we can split gles2
from //gpu

Bug: 795884
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I723280dcc8ab767348930f6ec4d0a454e4b769a4
Reviewed-on: https://chromium-review.googlesource.com/849419
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527480}
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/components/viz/common/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/content/app/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/content/common/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/content/test/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/gles2_conform_support/egl/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/common/flush_params.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/command_buffer_stub.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/direct_composition_child_surface_win.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/direct_composition_surface_win.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gles2_command_buffer_stub.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_channel.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_channel_manager.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_init.h
[add] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_ipc_service_export.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_buffer_factory.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_buffer_factory_android_hardware_buffer.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_buffer_factory_dxgi.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_manager.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_memory_tracking.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_vsync_provider_win.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/gpu_watchdog_thread.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/image_transport_surface.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/image_transport_surface_delegate.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/raster_command_buffer_stub.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/gpu/ipc/service/switches.h
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/headless/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/media/gpu/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/media/mojo/clients/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/media/mojo/services/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/services/ui/public/cpp/gpu/BUILD.gn
[modify] https://crrev.com/5f0b26759cdd6169ebd9fc2b247bd1aa623e312f/services/ui/ws/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a0aed1ef6909855f36ad693887dc68b13287e3

commit 83a0aed1ef6909855f36ad693887dc68b13287e3
Author: Antoine Labour <piman@chromium.org>
Date: Wed Jan 10 04:52:38 2018

Extract //gpu:gles2 into a separate component

This makes //gpu not depend on GLES2 details and will help reuse for
RasterDecoder and, later, Vulkan things.

Bug: 795884
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4b223e7bbd2a1596ae83feb8f7ab1f1ce2a186aa
Reviewed-on: https://chromium-review.googlesource.com/851446
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528240}
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/components/viz/common/gpu/in_process_context_provider.cc
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/content/public/browser/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/client/gles2_cmd_helper.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/common/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/common/debug_marker_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/buffer_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/context_group.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/context_state.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/decoder_context.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/error_state.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/framebuffer_completeness_cache.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/framebuffer_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gl_context_virtual.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gl_state_restorer_impl.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gl_stream_texture_image.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_clear_framebuffer.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_copy_tex_image.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_decoder.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gles2_cmd_srgb_converter.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gpu_fence_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gpu_switches.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/gpu_tracer.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/id_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/indexed_buffer_binding_host.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/logger.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/mailbox_manager_factory.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/mailbox_manager_impl.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/mailbox_manager_sync.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/memory_program_cache.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/passthrough_program_cache.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/path_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/program_cache.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/program_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/progress_reporter.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/query_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/raster_decoder.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/renderbuffer_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/sampler_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/service_discardable_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/service_transfer_cache.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/service_utils.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/shader_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/shader_translator.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/shader_translator_cache.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/transform_feedback_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/vertex_array_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/command_buffer/service/vertex_attrib_manager.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/config/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/gles2_conform_support/egl/BUILD.gn
[add] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/gpu_gles2_export.h
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/media/gpu/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/media/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/83a0aed1ef6909855f36ad693887dc68b13287e3/services/ui/public/cpp/gpu/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a2bf22135cf97689258a35dab6261324f8d2de

commit f8a2bf22135cf97689258a35dab6261324f8d2de
Author: Antoine Labour <piman@chromium.org>
Date: Fri Jan 12 21:03:49 2018

Move RasterCHROMIUM implementation to RasterInterface

This allows some decoupling between gles2 and cc.

Bug: 795884
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If7b98568c7e821414a712e9a391f3cf73c85b6fd
Reviewed-on: https://chromium-review.googlesource.com/862251
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529063}
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/paint/display_item_list.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/test/test_context_provider.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/test/test_context_support.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/test/test_context_support.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/GLES2/gl2chromium_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/context_support.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_c_lib_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_cmd_helper_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_implementation_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_interface_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_interface_stub_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_trace_implementation_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/raster_implementation_gles.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/raster_implementation_gles.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/cmd_buffer_functions.txt
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/common/gles2_cmd_format_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/f8a2bf22135cf97689258a35dab6261324f8d2de/ui/compositor/test/in_process_context_provider.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16d069116f6b4cf9378f6f7664283415f4ab40e5

commit 16d069116f6b4cf9378f6f7664283415f4ab40e5
Author: Antoine Labour <piman@chromium.org>
Date: Mon Jan 22 23:53:42 2018

Remove cc/paint from gles2_implementation.cc

This removes cc/paint types from ContextSupport and GLES2Implementation,
preferring generic types. The main functional modification is that
ContextSupport::CreateTransferCacheEntry gets split into
MapTransferCacheEntry+UnmapAndCreateTransferCacheEntry, with the
serialization itself moving to the callers.

Bug: 795884
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5aff728732ba2cd635a3c34d36b4ba5810479259
Reviewed-on: https://chromium-review.googlesource.com/879125
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531067}
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/paint/transfer_cache_entry.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/paint/transfer_cache_serialize_helper.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/paint/transfer_cache_serialize_helper.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/paint/transfer_cache_unittest.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/test/test_context_support.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/test/test_context_support.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/test/transfer_cache_test_helper.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/test/transfer_cache_test_helper.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/client_transfer_cache.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/client_transfer_cache.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/context_support.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/gles2_implementation.h
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/raster_implementation_gles.cc
[modify] https://crrev.com/16d069116f6b4cf9378f6f7664283415f4ab40e5/gpu/command_buffer/client/raster_implementation_gles_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/011cf776a913d87d218d84103d8de60a5facf88e

commit 011cf776a913d87d218d84103d8de60a5facf88e
Author: Antoine Labour <piman@chromium.org>
Date: Tue Jan 23 00:38:39 2018

Make gpu:raster component and move RasterImplementationGLES into it

Bug: 795884
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I768935020eaac55ac615338204679960e3dec915
Reviewed-on: https://chromium-review.googlesource.com/879176
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531089}
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/cc/BUILD.gn
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/components/viz/common/BUILD.gn
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/gpu/BUILD.gn
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/gpu/command_buffer/client/raster_implementation_gles.h
[add] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/gpu/raster_export.h
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/services/ui/public/cpp/gpu/BUILD.gn
[modify] https://crrev.com/011cf776a913d87d218d84103d8de60a5facf88e/ui/compositor/BUILD.gn

Components: Internals>GPU>Internals
Labels: -Pri-1 Pri-2
We can do more, but the client side (which was a more immediate concern) is essentially done, so lowering priority

Sign in to add a comment