New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

[gFeedback Prestable] Autofill selects wrong password for an account on vk.com

Project Member Reported by jainabhi...@chromium.org, Dec 18 2017

Issue description

Chrome Version: 63.0.3239.108 (So far observed only on this version)
OS: Windows 6.1+, MacOS X 10.13.2

The problem is fixed. 
Проблема устранена, но нужно очистить кэшированные файлы для vk.com. Нужно перейти chrome://settings/clearBrowserData и выбрать "Изображения и другие файлы, сохраненные в кеше" (Cached images and files), не забыв выбрать временной диапазон.

https://support.google.com/chrome/answer/2392709?hl=ru



User Comments
http://feedback/#/Report/84806440562
The site vk.com has 2 different accounts.
When switching from one to another, Smart Lock changes the password for entering one of the accounts with a password from the first account. Extremely hampering the work, you have to enter manually.

http://feedback/#/Report/84806075636
When you try to sign in to your VKontakte account, the window "To enter, select the required Google Smart Lock account" with saved passwords (By the way, before this window was not in the fields "login" and "password", the saved data was already displayed, which was very conveniently). When you click on any of the saved passwords, it gives an incorrect password, although you keep the password correctly (if you enter it manually into your account, you enter quietly)


http://feedback/#/Report/84802317090
Hello. When you go to the site "Vkontate" when choosing an account, it is suggested that Smart Lock google select an account, I choose, and I'm not writing the correct password, I have to manually enter the password. Prior to Smart Lock (the recent update), it was better. the password was autocomplete immediately and correctly. Please correct this

https://listnr/report/84811805282
Hello! =)
I have 3 accounts at vk.com for work and when I switch passwords between them I get confused, it just happened 2-3 days. You have to constantly reenter the password and save in the chrome password database. Previously, there were no such problems (((
Thank you! =)
 

Comment 1 by gov...@chromium.org, Dec 18 2017

Cc: ma...@chromium.org

Comment 2 by kolos@chromium.org, Dec 19 2017

Owner: pbomm...@chromium.org
Status: Unconfirmed (was: Untriaged)
I failed to reproduce the problem. Could the test team check it?
Problems with saving passwords in the social network. Replaces all passwords of several accounts by one. The password system does not work.
Labels: Needs-Triage-M63

Comment 5 by elyam...@gmail.com, Dec 19 2017

The same problem with our family. We have 2 accounts on VK. And it  takes a long time to fill in forms.

Comment 6 by gov...@chromium.org, Dec 19 2017

Cc: ranjitkan@chromium.org brajkumar@chromium.org
Cc: sc00335...@techmahindra.com
Labels: Triaged-ET
Unable to reproduce this issue on reported version 63.0.3239.108 using windows 10 with steps mentioned below.

1.Logged in to vk.com with "Continue with facebook" - logged in succesfully and saved credentials.
2. Logged out from say Account1 and gave valid mail id and password[say Account2] and clicked on Login
3. Seeing error when tried to login with Account2 even though they are valid credentials. Attaching screencast for reference.

Tried same scenario with Facebook.com and it worked fine.

1. Logged into Fb with Account1 and saved credentials >> Logged Off.
2. Logged in with Account 2 , saved credentials and logged off.
3. Now selected Account 1 from autofill data and able to log in sucessfully with Account 1 without entering paswword again.

@ jainabhishek: Please check the screencast and provide us your inputs
795878.mp4
5.6 MB View Download

Comment 8 by aleksy...@gmail.com, Dec 20 2017

такая же фигня пароли меняются сами в вк
У меня тоже самое, очень раздражает. Хочу переключится на другой профиль, выскакивает эта не нужная табличка (до последнего обновления, всё было отлично), и не правильный пароль говорит, приходится пароль вводить заново.
WTF

please fix
fix as fast as u can

Comment 13 Deleted

If possible please provide us below details:
1. steps which will reproduce this issue  
2. variations(which can be found under "Chrome://version") please attach them to bug
3. Which OS(Windows or Mac or Linux)

can someone on the bug who were able to reproduce the issue please let us know if this issue is specific to VK.com or can be reproducible on other webpages as well. 

Since we weren't able to reproduce the issue comment#2 and  7 .
Owner: ranjitkan@chromium.org
Please ignore above comment, Since test team(ranjit) was able to reproduce the issue and he would be posting steps and bisect result soon.
Just tried with VK.com and was able to reproduce the issue, below are the steps followed:

Precondition - 2 different usernames and password should be saved in chrome://settings/passwords

1) Log in to vk.com with a registered username and password
2) Log out 
3) Now login to the vk.com with the second registered username and password (Should be different password)
4) Log out
5) Now try to login with the second account again using autofill

Observed that vk.com provides a message "Please check that you have entered your login and password correctly."

Navigate back to chrome://settings/passwords and check the visibility of the passwords, observed that password gets replaced. Working on Bisect.

Thanks.!

Comment 17 by kolos@chromium.org, Dec 21 2017

Owner: kolos@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: vasi...@chromium.org
Labels: -Pri-2 -Needs-Feedback hasbisect-per-revision RegressedIn-60 Target-65 FoundIn-64 FoundIn-65 Target-63 FoundIn-63 Target-64 Pri-1
Below is the bisect obtained using per-revision bisect:

Bisect info:
============
60.0.3110.0 - Good Build:
60.0.3111.0 - Bad Build

CHANGELOG URL:
==============
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/a23b4bac4b5965383eb17f8c9942ac40e58fdf3e..2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d

Change URL:
=========== 
https://chromium.googlesource.com/chromium/src/+/2118f8bacddd5504dbea6a2906f2f3b7ee61aa8d

@vasilii: Looping you as well, request you to please take a look into it.

Comment 19 by kolos@chromium.org, Dec 21 2017

vasilii is OOO. I will try to fix.
Labels: ReleaseBlock-Stable

Comment 21 by kolos@chromium.org, Dec 21 2017

Cc: jochen@chromium.org jdoerrie@chromium.org mkwst@chromium.org
Credential Management API silently saves wrong credentials (it mixes username and password of different accounts). 

CredentialManagerImpl::OnProvisionalSaveComplete triggers |form_manager_->Update(*form_manager_->preferred_match())|

Unfortunately, I am not familiar with CM API. Adding folks who may help me to investigate. 
Labels: M-64
This is in reply to my question in comment#14, This issue is specific to VK.com and wasn't able to reproduce on https://myaccount.nytimes.com/ which also uses CM API.
Chrome constantly confuses passwords with accounts, it's impossible to work, please do something, I really like your development, I feed you. Thank you!
As a follow-up to #c16, these instructions reproduce it as well:

Same precondition: 2 different usernames and password should be saved in chrome://settings/passwords

1) Navigate to vk.com and observe that one of the saved accounts is auto-filled
2) Log into to vk.com with the *other* account, either via the Account Chooser popup or switching the accounts in the input field
3) Open chrome://settings/passwords and observe that the password of the first account is overwritten with the password of the second account.
ranjitkan@, can you please double-check the bisect results? I don't think the referenced CL could have broken this.

Jan, looks like PasswordFormManager::FindBestSavedMatch is not consulted at all in the CredentialManagerImpl? We should never be calling form_manager_->Update() with the preferred_match(), we should be calling it with the best saved matched retrieved like this: 

https://cs.chromium.org/chromium/src/components/password_manager/core/browser/password_form_manager.cc?rcl=9c0e4f94f2cfc6f7782a2cc763105fde55beb603&l=1008

I'm travelling, but if you can prepare a CL I'm happy to take a look.

Similar problem with passwords in contact
Just tried with VK.com and was able to reproduce the issue, below are the steps followed:

Precondition - 2 different usernames and password should be saved in chrome://settings/passwords

1) Log in to vk.com with a registered username and password
2) Log out 
3) Now login to the vk.com with the second registered username and password (Should be different password)
4) Log out
5) Now try to login with the second account again using autofill

Observed that vk.com provides a message "Please check that you have entered your login and password correctly."

Navigate back to chrome://settings/passwords and check the visibility of the passwords, observed that password gets replaced. Working on Bisect.

Thanks.!
I have a problem with vk.com. Passwords mercilessly hampered, this window is very annoying and doesnt give me access to accounts normally.

I hope the problem will be solved soon!

Thank you.
@Comment 26: With response the comment 26, Just rechecked the bisect and was getting the same result using the bisect script:

Note: On good builds, the Autofill dropdown appears and when selected users accordingly no issue is observed. Where as on bad builds there is suggestion bubble displayed from the password manager prompt and selecting it gives the bad results.

Thanks.!
УЖЕ ПОЛМЕСЯЦА ЭТО ДЛИТСЯ! HALF month that problem! 

Comment 33 by kolos@chromium.org, Dec 28 2017

Cc: kolos@chromium.org
Owner: jdoerrie@chromium.org
Sorry to see so many complaints. The fix is in progress (https://chromium-review.googlesource.com/c/chromium/src/+/843022). 
Project Member

Comment 34 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f35b6980f600ec93e167118c21959d5cbd7c5c4

commit 1f35b6980f600ec93e167118c21959d5cbd7c5c4
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Dec 28 19:23:35 2017

Fix Credential Management API Store() for existing Credentials

This changes fixes the Credential Management API to correctly handle
storing of already existing credentials. In the previous version
`preferred_match()` was updated, which is not necessarily the credential
selected by the user.

Bug:  795878 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I269f465861f44cdd784f0ce077e755191d3bd7bd
Reviewed-on: https://chromium-review.googlesource.com/843022
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526313}
[modify] https://crrev.com/1f35b6980f600ec93e167118c21959d5cbd7c5c4/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/1f35b6980f600ec93e167118c21959d5cbd7c5c4/components/password_manager/core/browser/credential_manager_impl.cc
[modify] https://crrev.com/1f35b6980f600ec93e167118c21959d5cbd7c5c4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Really, I thought it was only my problem, but it turns out that you did something wrong in the update. The browser of course is good, but it's a small issue brings a lot of inconvenience, fix faster please!
I'll wait for official updates
On the site vk.com I have 5 accounts with my husband. Passwords with English letters change to Russian and change them by places in a chaotic order. I tried to delete all saved passwords and enter them again, but after rebooting the computer everything is again confused.
Labels: Merge-Request-64
vk.com is the most popular social network in Russia. So, the bug affects on tens of millions of users. The fix is one line, well tested and carefully reviewed.
Project Member

Comment 39 by sheriffbot@chromium.org, Jan 2 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: engedy@chromium.org battre@chromium.org
Labels: Merge-Request-63
We would also like to merge the fix to Stable (M63) because there are so many complaints about the issue (you can see them in this bug). 

govind@: WDYT?
Такая же проблема. Несколько аккаунтов vk.com.
Переустановка браузера, чистка системы, смена операционной системы не помогли
Переустановка браузера или системы, к сожалению, не поможет. Проблема будет точно устранена в течение января (нужно ждать следующей версии), но попробуем быстрее. Просим прощения за неудобства.

Chrome при входе на сайт смешивает пароль и имя пользователя от разных аккаунтов. Поэтому при следующем логине ничего не работает.

Как временное решение можно создать несколько профилей в браузере и в каждом сохранить только по одному паролю для vk.com. Как работать с профилями можно найти здесь:
https://support.google.com/chrome/answer/2364824?co=GENIE.Platform%3DDesktop&hl=ru
https://support.google.com/chrome/answer/185277?co=GENIE.Platform%3DDesktop&hl=ru




Status: Fixed (was: Assigned)
As r526313 is part of the latest Canary I will mark this issue as fixed. The Merge-Request labels are still relevant, though.
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64. Branch:3282
Project Member

Comment 45 by bugdroid1@chromium.org, Jan 3 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c1c7d36795892ca5713b94b4e16d1d9408b1828

commit 0c1c7d36795892ca5713b94b4e16d1d9408b1828
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Jan 03 15:33:33 2018

Fix Credential Management API Store() for existing Credentials

This changes fixes the Credential Management API to correctly handle
storing of already existing credentials. In the previous version
`preferred_match()` was updated, which is not necessarily the credential
selected by the user.

Bug:  795878 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I269f465861f44cdd784f0ce077e755191d3bd7bd
Reviewed-on: https://chromium-review.googlesource.com/843022
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#526313}(cherry picked from commit 1f35b6980f600ec93e167118c21959d5cbd7c5c4)
Reviewed-on: https://chromium-review.googlesource.com/848856
Cr-Commit-Position: refs/branch-heads/3282@{#396}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/0c1c7d36795892ca5713b94b4e16d1d9408b1828/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/0c1c7d36795892ca5713b94b4e16d1d9408b1828/components/password_manager/core/browser/credential_manager_impl.cc
[modify] https://crrev.com/0c1c7d36795892ca5713b94b4e16d1d9408b1828/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 46 by ser...@gmail.com, Jan 6 2018

Same problem... 
Google Chrome 63.0.3239.132 (Официальная сборка), (64 бит)

Comment 47 by ser...@gmail.com, Jan 6 2018

How to fix it?
Когда же это закончится?! Уже больше 2х месяцев проблема, а системники и не шевелятся!!!

Comment 49 by kolos@chromium.org, Jan 11 2018

Проблема устранена. Нужно очистить кэшированные файлы для vk.com. Нужно перейти chrome://settings/clearBrowserData и выбрать "Изображения и другие файлы, сохраненные в кеше" (Cached images and files), не забыв выбрать временной диапазон.

https://support.google.com/chrome/answer/2392709?hl=ru
Project Member

Comment 50 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e9d3813944f19a889032f15baab2d35ebf920fd

commit 2e9d3813944f19a889032f15baab2d35ebf920fd
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Jan 11 13:08:24 2018

Credential Managment API should update the icon and display name.

Previously navigator.credentials.store() didn't update name and iconURL members of
PasswordCredential.

Bug:  795878 
Change-Id: Ifb98c2dfb4fc02314bfe14b367951320f69a9d0f
Reviewed-on: https://chromium-review.googlesource.com/860001
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528610}
[modify] https://crrev.com/2e9d3813944f19a889032f15baab2d35ebf920fd/components/password_manager/core/browser/credential_manager_impl.cc
[modify] https://crrev.com/2e9d3813944f19a889032f15baab2d35ebf920fd/components/password_manager/core/browser/credential_manager_impl_unittest.cc

Labels: -Merge-Request-63 Merge-Rejected-63
We're not planning any further M63 releases. Hence, rejecting merge to M63.

Is CL listed at #50 need to be merged to M64? If yes, pls request a merge. Thank you.
r528610 isn't critical enough to be merged. 
63.0.3239.132 version. The problem is still not fixed

Comment 54 by kolos@chromium.org, Jan 20 2018

Description: Show this description
Как была проблема, так и осталась!

Sign in to add a comment