No way to wait until HSTS data is cleared |
||
Issue descriptionWhen you clear data using a BrowsingDataRemover, it is supposed to wait until all relevant data is completely cleared, at which point it informs the use of such. However, TransportSecurityState::DeleteAllDynamicDataSince provides no way of waiting until the data is deleted. As a result, the data may not have been deleted by the time the user is told we're done clearing data. (See NetworkContext::ClearNetworkingHistorySince for where the method is called)
,
Nov 14
The transport security state is written to disk by an ImportantFileWriter, which can wait up to 10s. If we add a callback to TransportSecurityState::DeleteAllDynamicDataSince and wait for it to finish, we should probably use WriteNow() instead of ScheduleWrite() for deletions. I will see if I can implement something that works. https://cs.chromium.org/chromium/src/net/http/transport_security_persister.cc?l=246&rcl=d4f327badd2fdd83341ade8adb32d8151725a752
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee89d674b19fd16ff7de320faf58e5173164fe58 commit ee89d674b19fd16ff7de320faf58e5173164fe58 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Nov 29 15:12:28 2018 Add callback for HSTS deletion TransportSecurityState::DeleteAllDynamicDataSince provides no way to wait until the deletion is finished and written to disk. This adds a callback, so that clients can be informed when the deletion is finished. Bug: 795872 Change-Id: Ia0af06926d0ccfed07e229cd53b9d8ae587781c5 Reviewed-on: https://chromium-review.googlesource.com/c/1335939 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612193} [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/base/files/important_file_writer.cc [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/base/files/important_file_writer.h [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/net/http/transport_security_persister.cc [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/net/http/transport_security_persister.h [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/net/http/transport_security_persister_unittest.cc [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/net/http/transport_security_state.cc [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/net/http/transport_security_state.h [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/net/http/transport_security_state_unittest.cc [modify] https://crrev.com/ee89d674b19fd16ff7de320faf58e5173164fe58/services/network/network_context.cc
,
Nov 29
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0c670c2b6e80288880a0784bd0e76fe708abdd0 commit a0c670c2b6e80288880a0784bd0e76fe708abdd0 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Dec 03 13:22:19 2018 Bind base::PostTaskWithTraits directly Followup for https://crrev.com/c/1335939 Bug: 795872 Change-Id: I50aef1c108eb2afa09ff18361b77b1110a02df0b Reviewed-on: https://chromium-review.googlesource.com/c/1356539 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#613067} [modify] https://crrev.com/a0c670c2b6e80288880a0784bd0e76fe708abdd0/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm |
||
►
Sign in to add a comment |
||
Comment 1 by msramek@chromium.org
, Sep 5Owner: dullweber@chromium.org
Status: Assigned (was: Untriaged)