Origin is override by modifier amount for payment handler |
||
Issue descriptionExpected: BobPay test@bobpay.com https://bobpay.com $45.00 Actual: BobPay test@bobpay.com $45.00
,
Dec 18 2017
That's more challenging to do, we could consider it as improvement. The other solution I can think of is display origin in a single line on the bottom sheet which I think is much easier to do.
,
Dec 18 2017
here 'single' means a separate single line, like: Pay with BobPay, test@bobpay.xyz https://bobpay.com
,
Dec 18 2017
That works.
,
Jan 4 2018
Below is the screenshot to fix the override issue,
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/245ce226c29da9f8c2e3ab7b99d5614179beb880 commit 245ce226c29da9f8c2e3ab7b99d5614179beb880 Author: gogerald <gogerald@google.com> Date: Fri Jan 05 19:51:08 2018 [Payments] Do not override origin for payment handler Check comment #5 in the bug for screenshot. Bug: 795846 Change-Id: Ie4f55497938803ec86ed1bb2dc72ab4d1babf0ae Reviewed-on: https://chromium-review.googlesource.com/850834 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#527355} [modify] https://crrev.com/245ce226c29da9f8c2e3ab7b99d5614179beb880/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java [modify] https://crrev.com/245ce226c29da9f8c2e3ab7b99d5614179beb880/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/245ce226c29da9f8c2e3ab7b99d5614179beb880/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
,
May 28 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rouslan@chromium.org
, Dec 18 2017203 KB
203 KB View Download