New issue
Advanced search Search tips

Issue 795832 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS] Move ChromeCoordinator to ios/chrome/browser/ui/coordinators

Project Member Reported by kkhorimoto@chromium.org, Dec 18 2017

Issue description

This is where BrowserCoordinator lives, so it makes sense that ChromeCoordinator should also live there in the meantime.
 
Status: Started (was: Assigned)
crrev.com/c/833127
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef74b5d3a465a57cd191d692843bb9cc9820bd90

commit ef74b5d3a465a57cd191d692843bb9cc9820bd90
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Dec 20 22:15:53 2017

[iOS] Move ChromeCoordinator to ios/chrome/browser/ui/coordinators/

Bug:  795832 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I06e6c1d75b04b806853d5aa1ced268c494f0786c
Reviewed-on: https://chromium-review.googlesource.com/833127
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525492}
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/chrome_root_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/activity_services/activity_service_legacy_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/alert_coordinator/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/context_menu/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/context_menu/context_menu_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/coordinators/BUILD.gn
[rename] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/coordinators/chrome_coordinator.h
[rename] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/coordinators/chrome_coordinator.mm
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/download/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/download/pass_kit_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/elements/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/elements/activity_overlay_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/elements/selector_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/history_popup/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/page_info/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/page_info/page_info_legacy_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/address_edit_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/billing_address_selection_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/contact_info_edit_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/contact_info_selection_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/country_selection_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/credit_card_edit_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/payment_items_display_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/payment_method_selection_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/payment_request_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/payment_request_error_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/shipping_address_selection_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/qr_scanner/qr_scanner_legacy_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/reading_list/reading_list_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/tabs/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/tabs/tab_strip_legacy_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.h
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/tools_menu/BUILD.gn
[modify] https://crrev.com/ef74b5d3a465a57cd191d692843bb9cc9820bd90/ios/chrome/browser/ui/tools_menu/tools_menu_coordinator.h

Status: Fixed (was: Started)

Sign in to add a comment