Issue metadata
Sign in to add a comment
|
SSLUITestWithExtendedReporting.TestBrokenHTTPSReportingCloseTab test failing in official builds |
||||||||||||||||||||||
Issue descriptionI first observed this on the clang waterfall here: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/654 I don't remember where the "regular" (not TOT clang) official builder/testers are and I wasn't able to find them. This CL touched the file with those tests (https://chromium-review.googlesource.com/c/chromium/src/+/811604), so I think it's pretty likely the culprit. The code suggests that these tests are sensitive to the official-ness of the build: SSLUITestWithExtendedReporting() : SSLUITest() { // Certificate reports are only sent from official builds, unless this has // been called. CertReportHelper::SetFakeOfficialBuildForTesting(); Do you mind taking a look? I suspect you just have to build with "is_official_build = true" on Windows to reproduce.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42dd7c06f849280da808938099ca79303856412b commit 42dd7c06f849280da808938099ca79303856412b Author: Reid Kleckner <rnk@google.com> Date: Tue Dec 19 19:07:19 2017 Disable SSLUITest.TestBrokenHTTPSReportingCloseTab Win+official builds This should help green the Clang ToT waterfall. TBR=estark@chromium.org BUG=795820 Change-Id: I475524e9155b4c6e13d544283572c403f8ffedaa Reviewed-on: https://chromium-review.googlesource.com/834205 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#525095} [modify] https://crrev.com/42dd7c06f849280da808938099ca79303856412b/chrome/browser/ssl/ssl_browsertest.cc
,
Dec 22 2017
These test's are now failing on official desktop continuous Mac64 and Linux64, Please find the links to builder below : https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/6497 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/9991
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5f2b542466dc51ec76f68cd383697bd26a3f28f commit a5f2b542466dc51ec76f68cd383697bd26a3f28f Author: Mustafa Emre Acer <meacer@chromium.org> Date: Fri Dec 22 21:52:08 2017 Disable TestBrokenHTTPSReportingCloseTab SSL test on official builds Bug: 795820 Change-Id: I78202ba73a1c4e3d874a4faa973bb398fa2d30f8 TBR: estark@chromium.org Reviewed-on: https://chromium-review.googlesource.com/842855 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#526069} [modify] https://crrev.com/a5f2b542466dc51ec76f68cd383697bd26a3f28f/chrome/browser/ssl/ssl_browsertest.cc
,
Oct 26
This may have similar root causes as https://bugs.chromium.org/p/chromium/issues/detail?id=898645
,
Nov 8
,
Jan 17
(5 days ago)
When Edge tried to run this test, it failed for us. We investigated and found that the failure was due to a configuration difference for the Official builds where the fieldtrial_testing_config.json file is not present in that build.
SSLUITestWithExtendedReporting.TestBrokenHTTPSReportingCloseTab/0
The failure was because of
o CertReportHelper::ShouldShowCertificateReporterCheckbox returns false if there is no kFinchExperimentName ("ReportCertificateErrors") and
o CertReportHelper::ShouldReportCertificateError returns false it the value of kFinchParamName is not between 0 and 1 (included on both ends)
- The static file in chromium sets kFinchExperimentName and kFinchParamName to 1
- Chrome sets kFinchParamName through it’s experimentation servers
o For Stable channel, it is set to 0.2
o For Beta channel, it is set to 0.1
o For Dev channel, it is set to 0.5
o For Canary channel, it is set to 1.0
We fixed these failures by using `scoped_feature_list`.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by r...@chromium.org
, Dec 18 2017