Search-by-Image link on Chrome context menu broken on mobile |
|||||||||
Issue descriptionInternal bug: b/70786900 Device name: Reproduced on Pixel and nVidia Shield From "Settings > About Chrome" Application version: 63.0.3239.107 Operating system: Android 7.0.0; SHIELD Tablet K1 Build/NRD90M URLs (if applicable): Steps to reproduce: (1) View any image file (e.g. do an Image Search and click on the result). (2) Long-press to get context menu (3) Click "Search Google for this image" Expected result: Search-by-image result page Actual result: "This site can't be reached" Issue is being noticed in the wild: https://productforums.google.com/forum/#!topic/chrome/kQThshRB8Nw
,
Dec 18 2017
Raising priority here given the circumstances described in user report and multiple Googlers reproducing. I can't repro on my Pixel 2 XL on O MR1 FWIW. We should have someone try to repro on dev (https://play.google.com/store/apps/details?id=com.chrome.dev&hl=en) to see if this reproduces in M64 as well or just M63 stable. We should also have someone attach a bug report (to the internal bug).
,
Dec 18 2017
I am able to repro consistently on Pixel 1 Android 8.1.0, Chrome 63.0.3239.111
,
Dec 18 2017
issue 795813 seems similar. But it is being reproted on M62. We are trying and will update here if we can repro.
,
Dec 18 2017
FWIW, the bug is *not* present on iOS w/ Chrome version 63.0.3239.73.
,
Dec 18 2017
hongchichang@ is there any user feedback about this issue?
,
Dec 18 2017
Also repros consistently on Pixel 1 Android 8.1.0, Chrome 64.0.3282.29
,
Dec 18 2017
,
Dec 18 2017
I can reproduce the issue consistently on my Pixel 1 XL Chrome 63.0.3239.111 on Android 8.1.0. Build number: Marlin-userdebug 8.1.0 OPM1.171019.012 4470837 dev-keys
,
Dec 18 2017
,
Dec 18 2017
I see this when the issue happens via remote Chrome debugging: The FetchEvent for "https://www.google.com/searchbyimage/upload" resulted in a network error response: an object that was not a Response was passed to respondWith(). Promise resolved (async) sw_xb @ serviceworker?pwa=search:71 (anonymous) @ serviceworker?pwa=search:70
,
Dec 18 2017
(that was on Pixel 1 XL Chrome 63.0.3239.111 on Android 8.1)
,
Dec 18 2017
I am able to repro this issue on M63 as well as M62. on Pixel / 8.0 and Samsung S6 / 5.1.1 It doesn't happen for images on any site first. It starts happening only after I do this, 1. Open a Tab and search for something like 'flowers' 2. Tap on 'Images' from the SRP 3. Longpress on the image and choose 'Search Google for this image' Observed: 'This site cannot be reached' After this it repros on images on other sites too.
,
Dec 18 2017
Reports start coming in in 12/15 late afternoon. Here are some reports with system log: https://listnr.corp.google.com/report/84811900345 https://listnr.corp.google.com/report/84811860837 https://listnr.corp.google.com/report/84810623240 https://listnr.corp.google.com/report/84810623240 https://listnr.corp.google.com/report/84809104329 Here are link to all play review & in-app feedback reprots: https://listnr.corp.google.com/product/282/reports?searchText=search%20image&filter=0&dateRange=30&sources=8590027391,8590013633&versions=63.0.3239.111
,
Dec 18 2017
,
Dec 18 2017
All reports are on 63.0.3239.111 Can we bisect this issue? Please try to reproduce on 63.0.3239.107 and also 63.0.3239.83 if possible.
,
Dec 18 2017
From c#13: "I am able to repro this issue on M63 as well as M62" Did the search team enable experiments that could have caused this? If we can repro on 62 but reports only started on 12/15 that's indicative of an external factor IMO.
,
Dec 18 2017
cmasso@, in the Listnr link Robert sent, I think there's a version filter applied for M63; if I remove it I see other reports... https://listnr.corp.google.com/report/84786796788 That's from M62 with identical circumstances on 13 Dec.
,
Dec 18 2017
Another M62: https://listnr.corp.google.com/report/84804395467
,
Dec 18 2017
There are 12 reports since 12/12 in 63.0.3239.84 and 63.0.3239.107 from in-app feedback and play review: https://listnr.corp.google.com/product/282/issue/a11:69647b14:930853?collapseIssueChart=true&dateRange=30&sources=8590027391,8590013633&versions=63.0.3239.83,63.0.3239.107
,
Dec 18 2017
Just had a chat with Robert and yes, the reports are from Dec 12th. We need to find an owner to look into this issue.
,
Dec 18 2017
Not sure if Internals>Network is the right component here but adding Chris to take a look.
,
Dec 18 2017
I think at this point the owner should be the search by image team given what we're seeing - it may be a Chrome bug, but if it's back to M62 then it's likely we should roll back whatever's causing this to start failing now. Thoughts on removing RB here and tagging as ExternalDependency?
,
Dec 18 2017
Unfortunately Chris is OOO
,
Dec 18 2017
I haven't been able to repro the issue in M61 so far. But can consistently repro it in M62 and M63 on these two devices. I am trying to bisect further. Also Note that I was not able to repro this issue in M63 on a Pixel 2XL / 8.0.0. So it looks like its not happening on all devices.
,
Dec 18 2017
Does it reproduce on all OS versions?
,
Dec 18 2017
So far I have been able to repro on 2 devices out of 3 which I tried.
,
Dec 18 2017
..pressed send too soon. I was able to repro on OS versions 8.0 and 5.1.1. But it didn't repro on another device with 8.0.
,
Dec 18 2017
,
Dec 18 2017
The search support team is not aware of this issue. They are escalating to search Eng now I am being told.
,
Dec 18 2017
My bisect did not provide a code change CL. Its a version change CL. Then may be its a GWS experiment which is enabled Chrome M62 and above. Good build: 61.0.3163.0 Bad build: 61.0.3164.0 Regression range: https://chromium.googlesource.com/chromium/src/+log/61.0.3163.0..62.0.3164.0?pretty=fuller&n=10000 Good commit: 488564 Bad commit: 488565 Suspect CL: https://chromium.googlesource.com/chromium/src/+/67d808464f515952ee0276976fb73f30ef209ca9
,
Dec 18 2017
Bad build above should probably say 62.0.3164.0. We should check recent Finch changes as well actually... Just to be safe. Unsure if image team experiments track Chrome versions so closely.
,
Dec 18 2017
Oops typo. Yes the BAD Build: 62.0.3164.0
,
Dec 18 2017
I think this has been identified as a bad service worker released on the search side. Details in b/70786900
,
Dec 18 2017
Thanks to all who gathered data to help track this down!
,
Dec 18 2017
Thanks!
,
Dec 18 2017
,
Dec 19 2017
Issue 795616 has been merged into this issue.
,
Dec 19 2017
Many thanks to everyone who helped us debug. The Search UI team has identified the cause of the issue and has released a temporary fix. We will switch back to b/70786900 for further updates. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by howardzhou@google.com
, Dec 18 2017