New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795800 link

Starred by 6 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

Search-by-Image link on Chrome context menu broken on mobile

Project Member Reported by smo@google.com, Dec 18 2017

Issue description

Internal bug: b/70786900

Device name: Reproduced on Pixel and nVidia Shield

From "Settings > About Chrome"
Application version: 63.0.3239.107
Operating system: Android 7.0.0; SHIELD Tablet K1 Build/NRD90M

URLs (if applicable):

Steps to reproduce:
(1) View any image file (e.g. do an Image Search and click on the result).
(2) Long-press to get context menu
(3) Click "Search Google for this image"

Expected result: Search-by-image result page


Actual result: "This site can't be reached"

Issue is being noticed in the wild: https://productforums.google.com/forum/#!topic/chrome/kQThshRB8Nw


 
It seems this issue was reported 3 days ago: https://productforums.google.com/forum/#!topic/chrome/kQThshRB8Nw

The users said that desktop Chrome MaxOSX works just like on AmazonFireTablet, so the issue seems to be coming from Android Chrome.

I tried it in Desktop Chrome on MacOS and the https://www.google.com/searchbyimage/upload link worked for me.
Here's a video: https://photos.app.goo.gl/m9ESygTJRclztkn83.
Labels: -Pri-3 ReleaseBlock-Stable M-63 Pri-1
Raising priority here given the circumstances described in user report and multiple Googlers reproducing.  I can't repro on my Pixel 2 XL on O MR1 FWIW.

We should have someone try to repro on dev (https://play.google.com/store/apps/details?id=com.chrome.dev&hl=en) to see if this reproduces in M64 as well or just M63 stable.  We should also have someone attach a bug report (to the internal bug).
I am able to repro consistently on Pixel 1 Android 8.1.0, Chrome 63.0.3239.111
issue 795813 seems similar. But it is being reproted on M62. We are trying and will update here if we can repro.

Comment 5 by smo@google.com, Dec 18 2017

FWIW, the bug is *not* present on iOS w/ Chrome version 63.0.3239.73.

Comment 6 by cmasso@google.com, Dec 18 2017

Cc: hongchic...@chromium.org candr...@chromium.org cma...@chromium.org
hongchichang@ is there any user feedback about this issue?
Also repros consistently on Pixel 1 Android 8.1.0, Chrome 64.0.3282.29
Cc: aska...@chromium.org
I can reproduce the issue consistently on my Pixel 1 XL Chrome 63.0.3239.111 on Android 8.1.0. 

Build number: Marlin-userdebug 8.1.0 OPM1.171019.012 4470837 dev-keys
Cc: amineer@chromium.org
 Issue 795833  has been merged into this issue.

Comment 11 by sa...@google.com, Dec 18 2017

I see this when the issue happens via remote Chrome debugging:

The FetchEvent for "https://www.google.com/searchbyimage/upload" resulted in a network error response: an object that was not a Response was passed to respondWith().
Promise resolved (async)
sw_xb @ serviceworker?pwa=search:71
(anonymous) @ serviceworker?pwa=search:70

Comment 12 by sa...@google.com, Dec 18 2017

(that was on Pixel 1 XL Chrome 63.0.3239.111 on Android 8.1)
I am able to repro this issue on M63 as well as M62. on Pixel / 8.0 and Samsung S6 / 5.1.1
It doesn't happen for images on any site first. It starts happening only after I do this,
1. Open a Tab and search for something like 'flowers'
2. Tap on 'Images' from the SRP
3. Longpress on the image and choose 'Search Google for this image'

Observed: 'This site cannot be reached'

After this it repros on images on other sites too.

Components: Internals>Network

Comment 16 by cmasso@google.com, Dec 18 2017

All reports are on 63.0.3239.111 Can we bisect this issue? Please try to reproduce on 63.0.3239.107 and also 63.0.3239.83 if possible.
From c#13: "I am able to repro this issue on M63 as well as M62"

Did the search team enable experiments that could have caused this?  If we can repro on 62 but reports only started on 12/15 that's indicative of an external factor IMO.
cmasso@, in the Listnr link Robert sent, I think there's a version filter applied for M63; if I remove it I see other reports...

https://listnr.corp.google.com/report/84786796788

That's from M62 with identical circumstances on 13 Dec.

Comment 21 by cmasso@google.com, Dec 18 2017

Just had a chat with Robert and yes, the reports are from Dec 12th. We need to find an owner to look into this issue.

Comment 22 by cmasso@google.com, Dec 18 2017

Cc: cbentzel@chromium.org
Not sure if Internals>Network is the right component here but adding Chris to take a look.
I think at this point the owner should be the search by image team given what we're seeing - it may be a Chrome bug, but if it's back to M62 then it's likely we should roll back whatever's causing this to start failing now.

Thoughts on removing RB here and tagging as ExternalDependency?

Comment 24 by cmasso@google.com, Dec 18 2017

Unfortunately Chris is OOO
I haven't been able to repro the issue in M61 so far. But can consistently repro it in M62 and M63 on these two devices. I am trying to bisect further.

Also Note that I was not able to repro this issue in M63 on a Pixel 2XL / 8.0.0. So it looks like its not happening on all devices.

Comment 26 by cmasso@google.com, Dec 18 2017

Does it reproduce on all OS versions?
So far I have been able to repro on 2 devices out of 3 which I tried.
..pressed send too soon.

I was able to repro on OS versions 8.0 and 5.1.1. But it didn't repro on another device with 8.0. 

Comment 30 by cmasso@google.com, Dec 18 2017

The search support team is not aware of this issue. They are escalating to search Eng now I am being told.
My bisect did not provide a code change CL. Its a version change CL. Then may be its a GWS experiment which is enabled Chrome M62 and above.


Good build: 61.0.3163.0
Bad build: 61.0.3164.0
Regression range: https://chromium.googlesource.com/chromium/src/+log/61.0.3163.0..62.0.3164.0?pretty=fuller&n=10000

Good commit: 488564
Bad commit: 488565
Suspect CL: https://chromium.googlesource.com/chromium/src/+/67d808464f515952ee0276976fb73f30ef209ca9

Bad build above should probably say 62.0.3164.0. 

We should check recent Finch changes as well actually... Just to be safe. Unsure if image team experiments track Chrome versions so closely. 
Oops typo. Yes the BAD Build: 62.0.3164.0

Comment 34 by sa...@google.com, Dec 18 2017

I think this has been identified as a bad service worker released on the search side. Details in b/70786900
Status: WontFix (was: Unconfirmed)
Thanks to all who gathered data to help track this down!

Comment 36 by cmasso@google.com, Dec 18 2017

Thanks!
Labels: hasbisect-per-revision Mobile-te

Comment 38 by aska...@google.com, Dec 19 2017

Cc: nyerramilli@chromium.org ben@chromium.org sandeepkumars@chromium.org ligim...@chromium.org
 Issue 795616  has been merged into this issue.
Many thanks to everyone who helped us debug. The Search UI team has identified the cause of the issue and has released a temporary fix. We will switch back to b/70786900 for further updates.

Sign in to add a comment