Issue metadata
Sign in to add a comment
|
88kb (68+20) regression in resource_sizes (MonochromePublic.apk) at 524638:524638 |
||||||||||||||||||||
Issue descriptionCaused by “[Ribbon] Start moving getPropertyName and similar to CSSProperty” Commit: 85b6741bea73eeb6b9705399cb37d33f4f73f383 Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=524638 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Almost all the increase is in .text sections: Section Sizes (Total=67.5kb (69116 bytes)): .bss: 4.22kb (4320 bytes) (not included in totals) .data: 0 bytes (0 bytes) (0.0%) .data.rel.ro: 9.97kb (10208 bytes) (14.8%) .other: 9 bytes (9 bytes) (0.0%) .pak.nontranslated: 0 bytes (0 bytes) (0.0%) .pak.translations: 0 bytes (0 bytes) (0.0%) .rel.dyn: 1568 bytes (1568 bytes) (2.3%) .rodata: 6.45kb (6608 bytes) (9.6%) .text: 49.5kb (50723 bytes) (73.4%) It looks like this increase was probably unexpected or might be avoidable. Please have a look and either: Close as “Won't Fix” with a short justification, or Land a revert / fix-up. 2810 symbols added (+), 551 changed (~), 168 removed (-), 687730 unchanged (not shown) Of changed symbols, 3112 grew, 417 shrank Number of unique symbols 519571 -> 522214 (+2643) 0 paths added, 0 removed, 281 changed There are very many symbols like the following: + 314) 36789 (54.4%) t@0x1b5e528 120 (0->120) third_party/WebKit/Source/core/css/properties/shorthands/BorderStyle.cpp blink::CSSShorthand::BorderStyle::GetPropertyNameAtomicString const + 315) 36909 (54.6%) t@0x1b5e5cc 120 (0->120) third_party/WebKit/Source/core/css/properties/shorthands/BorderTop.cpp blink::CSSShorthand::BorderTop::GetPropertyNameAtomicString const Are these absolutely necessary or can we avoid adding them to basically every WebKit file?
,
Dec 18 2017
You can run this to see the full output, may have to view the extended diff.txt file: tools/binary_size/diagnose_bloat.py --cloud 85b6741bea73eeb6b9705399cb37d33f4f73f383
,
Dec 18 2017
The other 20kb is from this: e9cc36e4b58dfa03c0e882d6a9a9c8322e03a8f3 Probably similar cause.
,
Jan 10 2018
Ping rjwright - ptal.
,
Oct 22
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 18 2017