New issue
Advanced search Search tips

Issue 795781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.5% regression in sizes at 524492:524494

Project Member Reported by chiniforooshan@chromium.org, Dec 18 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 18 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=795781

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=96f67322cd2e0c6e3e1c8db232d88a9be905ce9c2e8e100f991739c868a57f27


Bot(s) for this bug's original alert(s):

win
win-32
Owner: sky@chromium.org
Status: (was: Untriaged)
Looks like this is due to https://chromium-review.googlesource.com/830685. sky@, is this size regression expected?

Comment 3 by sky@chromium.org, Jan 2 2018

Cc: -chiniforooshan@chromium.org
Labels: OS-Windows
Owner: chiniforooshan@chromium.org
https://chromium-review.googlesource.com/830685 is, for the most part, chromeos specific and shouldn't impact windows. I would not expect an increase in windows from this change. Are you sure you have the right regression range?
Cc: chiniforooshan@chromium.org
Owner: rbpotter@chromium.org
Status: Assigned
Sorry; it is actually the commit before yours: https://chromium-review.googlesource.com/704262. I don't know why one of the graphs (win-32) points to your change.
I verified the size increase between r524492 and r524493 locally. Then I reverted to r524492 and applied all the changes from r524493 except for chrome/browser/printing/print_view_manager_base.* and the size hasn't increased. So something in PrintViewManagerBase is causing this. We'll need to dig into the changes there and figure out why.
Cc: rbpotter@chromium.org
Owner: thestig@chromium.org
I think this is because we added a PdfMetafileSkia use on Windows that was not strictly necessary.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c0f16663d5dc609494f08d312ad462dbfb6a8c

commit 30c0f16663d5dc609494f08d312ad462dbfb6a8c
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Jan 17 05:11:22 2018

Remove PdfMetafileSkia use from PrintViewManagerBase on Windows.

It is not strictly necessary and it causes a 200 KB size increase.

BUG= 795781 

Change-Id: I9fd3e2b12cc1fc5833c51c6f11e906f995562bb5
Reviewed-on: https://chromium-review.googlesource.com/869360
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529617}
[modify] https://crrev.com/30c0f16663d5dc609494f08d312ad462dbfb6a8c/chrome/browser/printing/print_view_manager_base.cc

Cc: m...@chromium.org
Status: Fixed (was: Assigned)
There's a green alert firing on the Win perf bot for the size decrease. +miu (current perf sheriff) FYI.
Components: Internals>Printing

Sign in to add a comment