Issue metadata
Sign in to add a comment
|
0.5% regression in sizes at 524492:524494 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 19 2017
Looks like this is due to https://chromium-review.googlesource.com/830685. sky@, is this size regression expected?
,
Jan 2 2018
https://chromium-review.googlesource.com/830685 is, for the most part, chromeos specific and shouldn't impact windows. I would not expect an increase in windows from this change. Are you sure you have the right regression range?
,
Jan 2 2018
Sorry; it is actually the commit before yours: https://chromium-review.googlesource.com/704262. I don't know why one of the graphs (win-32) points to your change.
,
Jan 17 2018
I verified the size increase between r524492 and r524493 locally. Then I reverted to r524492 and applied all the changes from r524493 except for chrome/browser/printing/print_view_manager_base.* and the size hasn't increased. So something in PrintViewManagerBase is causing this. We'll need to dig into the changes there and figure out why.
,
Jan 17 2018
I think this is because we added a PdfMetafileSkia use on Windows that was not strictly necessary.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30c0f16663d5dc609494f08d312ad462dbfb6a8c commit 30c0f16663d5dc609494f08d312ad462dbfb6a8c Author: Lei Zhang <thestig@chromium.org> Date: Wed Jan 17 05:11:22 2018 Remove PdfMetafileSkia use from PrintViewManagerBase on Windows. It is not strictly necessary and it causes a 200 KB size increase. BUG= 795781 Change-Id: I9fd3e2b12cc1fc5833c51c6f11e906f995562bb5 Reviewed-on: https://chromium-review.googlesource.com/869360 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#529617} [modify] https://crrev.com/30c0f16663d5dc609494f08d312ad462dbfb6a8c/chrome/browser/printing/print_view_manager_base.cc
,
Jan 17 2018
There's a green alert firing on the Win perf bot for the size decrease. +miu (current perf sheriff) FYI.
,
Mar 1 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 18 2017