Issue metadata
Sign in to add a comment
|
59.8% regression in system_health.common_desktop at 524359:524389 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 18 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/168a4dc6040000
,
Dec 18 2017
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/168a4dc6040000
,
Dec 18 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16f441a6040000
,
Dec 18 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16f441a6040000 Statically link fontconfig on Linux By thomasanderson@chromium.org ยท Fri Dec 15 15:53:31 2017 chromium @ 4f1a60552748d150783655ee6f7b6f7084e3af95 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Dec 18 2017
+sullivan@ addressing_performance_regressions.md says that the bisect bot should have posted a message on this bug with instructions on how to reproduce the test, but it's missing in this case. Which test do I need to run?
,
Dec 18 2017
I think the documentation is stale and should be updated. Meanwhile, the pinpoint job (https://pinpoint-dot-chromeperf.appspot.com/job/16f441a6040000) has this information about the failure: benchmark: system_health.common_desktop story: browse.search.google.india configuration: linux-release To run the test locally, use: src/tools/perf/run_benchmark -v --browser=release --output-format=html --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google.india system_health.common_desktop --output-dir=<SOME DIR>
,
Dec 18 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15df5476040000
,
Dec 18 2017
Thanks chiniforooshan@. I ran the tests locally and got the attached results. Runs 2 and 3 are without the CL, and 4 and 5 are with the CL applied. I don't see a significant difference in the timings though.
,
Dec 19 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/15df5476040000 Statically link fontconfig on Linux By thomasanderson@chromium.org ยท Fri Dec 15 15:53:31 2017 chromium @ 4f1a60552748d150783655ee6f7b6f7084e3af95 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Dec 19 2017
Oh, sorry. If you want to try with local changes, instead of --browser=release please use --browser=exact --browser-executable=<path to your locally built chrome binary>.
,
Dec 22 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14fc9d31040000
,
Dec 22 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14fc9d31040000 Roll HarfBuzz to 1.7.3 plus hb_set fix By drott@chromium.org ยท Wed Dec 20 13:26:18 2017 chromium @ a14e00ae9bc6a9263bbfb249ec51b4ed6a7635c1 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Dec 22 2017
Looks like things went back to normal after the harfbuzz roll (also the CL was reverted before the hb roll, but pinpoint didn't identify that as the source of the speedup) |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 18 2017