New issue
Advanced search Search tips

Issue 795775 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 795323
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.4%-3.1% regression in system_health.memory_mobile at 524055:524108

Project Member Reported by chiniforooshan@chromium.org, Dec 18 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 18 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=795775

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=47937dca1e24a1a919876860507988b71c1da5ac8be12eb9c31bb691bde7f828


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 18 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_media/load_media_imgur
  Change       : 1.98% | 18219876.0 -> 18607127.1111

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/068c786ea56aff47173f8c3e1f16329bb0effd6d..54857f4351ae59436f7a7363204b6b6bca309140


Revision             Result                   N
chromium@524054      18219876 +- 595932       14       good
chromium@524056      18201793 +- 563424       14       good
chromium@524057      ---                      ---      build failure
chromium@524058      18489798 +- 1449566      21       bad
chromium@524061      18634946 +- 1436996      14       bad
chromium@524067      18649332 +- 648947       9        bad
chromium@524081      18565255 +- 923993       14       bad
chromium@524108      18607127 +- 474498       9        bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.imgur system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959854643810161744


For feedback, file a bug with component Speed>Bisection
Retry...
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Dec 19 2017


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_news/load_news_washingtonpost


Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.washingtonpost system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959763864986335520


For feedback, file a bug with component Speed>Bisection
Components: Speed>Bisection
Cannot reproduce. I'll add this bug to the Speed>Bisection component in case someone there have ideas what to do. The graph clearly shows a regression.
The bisect in #6 failed since it couldn't run the load.news.washingtonpost story, but the first bisect succeeded but there were build failures. You could try running the first one again (load.media.imgur), might have just timed out waiting. It looks like that middle cl is an ios cl, so shouldn't have any reason to fail building.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Dec 21 2017

Mergedinto: 795323
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ali Ijaz Sheikh
  Commit : 4623b8223b487fb18b3af12fcf4fdbb7a194eca3
  Date   : Tue Dec 12 19:12:03 2017
  Subject: [heap] replace DisableInlineAllocationSteps with PauseAllocationObservers

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_media/load_media_imgur
  Change       : 1.82% | 18244678.2857 -> 18647861.1429

Revision                           Result                   N
chromium@524054                    18244678 +- 780571       14      good
chromium@524056                    18267581 +- 581127       14      good
chromium@524056,v8@10d9c31488      18260812 +- 888804       21      good
chromium@524056,v8@4623b8223b      18492627 +- 308804       9       bad       <--
chromium@524056,v8@1220809924      18563559 +- 1211123      14      bad
chromium@524056,v8@aba57b1164      18555143 +- 1210809      14      bad
chromium@524056,v8@27da2f8ccf      18500809 +- 1288390      21      bad
chromium@524056,v8@d5fbf0edcf      18433520 +- 1129525      21      bad
chromium@524057                    18473991 +- 1208730      21      bad
chromium@524058                    18626460 +- 740404       14      bad
chromium@524062                    18637819 +- 562209       6       bad
chromium@524068                    18476027 +- 655656       14      bad
chromium@524082                    18552189 +- 713608       9       bad
chromium@524108                    18647861 +- 804288       14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.imgur system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959671995251028576


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment