New issue
Advanced search Search tips

Issue 795760 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 799594

Blocking:
issue 778749



Sign in to add a comment

Viz Telemetry Testing

Project Member Reported by jonr...@chromium.org, Dec 18 2017

Issue description

We need to make sure that --enable-viz doesn't regress telemetry_unittests and telemetry_perf_unittests.

Let's bring them up on FYI bots first, and then fix everything that's broken.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e2dd938855a4d490b7f3f9221107373b93c6a83

commit 0e2dd938855a4d490b7f3f9221107373b93c6a83
Author: Jonathan <jonross@chromium.org>
Date: Mon Dec 18 17:07:19 2017

Fix Viz Telemetry Perf config

telemetry_perf_unittests needs --xvfb this change adds that.
Also adds one more skip for telemetry_unittests.

TBR=sky@chromium.org

Bug:  795760 
Change-Id: Ic5e1f09bdf94397c11d1b25fa71e783a4a9e7a4d
Reviewed-on: https://chromium-review.googlesource.com/832766
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524731}
[modify] https://crrev.com/0e2dd938855a4d490b7f3f9221107373b93c6a83/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/0e2dd938855a4d490b7f3f9221107373b93c6a83/testing/buildbot/test_suites.pyl

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a43d11545fdd18b8eaa327fc1006ddd5f0b81c

commit c8a43d11545fdd18b8eaa327fc1006ddd5f0b81c
Author: Jonathan <jonross@chromium.org>
Date: Fri Dec 22 00:28:11 2017

Add viz specific telemetry_perf_unittests config

Currently there are some telemetry_perf_unittests failing on Linux Viz trybot.
These are being ran with --enable-viz.

However when I try them locally I get the same tests failing with and without
--enable-viz.

I'd like to confirm that viz is not responsible for the failures so that I can
file appropriate bugs.

This change adds a new isolate definition for telemetry_perf_unittests_viz
which copies the normal config of telemetry_perf_unittests and adds --enable-viz

The Linux Viz config is also updated to run both versions of the suite.

Bug:  795760 
Change-Id: I63d8fcd788da3b8f416ebdf33acbc9b89caaf9ca
Reviewed-on: https://chromium-review.googlesource.com/839965
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525871}
[modify] https://crrev.com/c8a43d11545fdd18b8eaa327fc1006ddd5f0b81c/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/c8a43d11545fdd18b8eaa327fc1006ddd5f0b81c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/c8a43d11545fdd18b8eaa327fc1006ddd5f0b81c/testing/buildbot/test_suites.pyl

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b9799f3477553ff169933c5007cca6d4a29c21c

commit 8b9799f3477553ff169933c5007cca6d4a29c21c
Author: Jonathan <jonross@chromium.org>
Date: Tue Jan 02 17:32:25 2018

Fix telemetry_perf_unittests_viz

When adding telemetry_perf_unittests_viz I thought the isolate would just run
the targeted script. However it also tries to build a target of the same name.
Since this is an override, there is no target.

This change adds the executable override to the isolate definition.

TBR=dpranke@chromium.org

Bug:  795760 
Change-Id: I2482275fffd3cfdee542ddb509f287d37fb75d1a
Reviewed-on: https://chromium-review.googlesource.com/847420
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526497}
[modify] https://crrev.com/8b9799f3477553ff169933c5007cca6d4a29c21c/testing/buildbot/gn_isolate_map.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d36f4e564c7ad8e4e5d9033f2791052c29846020

commit d36f4e564c7ad8e4e5d9033f2791052c29846020
Author: Jonathan <jonross@chromium.org>
Date: Wed Jan 03 02:59:59 2018

Remove telemetry_perf_unittestes_viz config

The gn_isolate_map to telemetry_perf_unittestes_viz doesn't work as there is
no associated build target. Providing an executable override doesn't seem to
resolve this. I'm removing the config to get the Linux Viz bot back up and
running until the error can be sorted out.

TBR=dpranke@chromium.org

Bug:  795760 
Change-Id: I28dd3bc515aaa16bae59258ba0b1bb0b42ac4676
Reviewed-on: https://chromium-review.googlesource.com/846231
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526604}
[modify] https://crrev.com/d36f4e564c7ad8e4e5d9033f2791052c29846020/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d36f4e564c7ad8e4e5d9033f2791052c29846020/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/d36f4e564c7ad8e4e5d9033f2791052c29846020/testing/buildbot/test_suites.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bea571638c658ec11fcd5216ca09e5ae71626b2

commit 9bea571638c658ec11fcd5216ca09e5ae71626b2
Author: Jonathan <jonross@chromium.org>
Date: Fri Jan 05 01:00:20 2018

Setup Viz Telemetry_Perf_Unittests

Try setting up an isolate override of telemetry_perf_unittests within
test_suites.pyl. This is only for the Linux Viz bot

Bug:  795760 
Change-Id: I40a41fd0352d751990da98ac6b32e51818f1397c
Reviewed-on: https://chromium-review.googlesource.com/851220
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527179}
[modify] https://crrev.com/9bea571638c658ec11fcd5216ca09e5ae71626b2/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9bea571638c658ec11fcd5216ca09e5ae71626b2/testing/buildbot/test_suites.pyl

Blockedon: 799594
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3dd9d1501606ad379362337d0f8b9b3239fab68

commit f3dd9d1501606ad379362337d0f8b9b3239fab68
Author: Jonathan <jonross@chromium.org>
Date: Fri Jan 05 23:49:32 2018

Update Viz Linux Telemetry Configs

Update telemetry_perf_unittests_viz to skip the known failing tests.

Split its telemetry_unittests config in two. One explicitly named for running
with viz "telemetry_unittests_viz" and the classic one. This will let us confirm
if the failures we are seeing are Viz only.

Bug:  795760 
Change-Id: If0d2149be8c772921a55ce87dc8f0e0bb42a2a23
Reviewed-on: https://chromium-review.googlesource.com/853112
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527431}
[modify] https://crrev.com/f3dd9d1501606ad379362337d0f8b9b3239fab68/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f3dd9d1501606ad379362337d0f8b9b3239fab68/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)
We have testing coverage now.

Specific Failures are being tracked in  issue 799594  which is assigned.

Sign in to add a comment