New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Win Builder (dbg) builds on luci.chromium.ci are failing

Project Member Reported by dullweber@chromium.org, Dec 18 2017

Issue description

https://ci.chromium.org/p/chromium/g/main/console

The builds in chromium.win/debug/builder/32 are failing about 50% of the time. It looks like the successful builds are running on  buildbot.
(e.g. https://ci.chromium.org/buildbot/chromium.win/Win%20Builder%20(dbg)/40533)

The non successful builds are on luci.chromium.ci
(e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20Builder%20(dbg)/133)

Please check what is happening here.
 
Description: Show this description
Cc: dullweber@chromium.org
Labels: Infra-Troopers
Cc: tandrii@chromium.org
Components: -Infra Infra>Platform>Milo
Labels: -Infra-Troopers
Status: Unconfirmed (was: Untriaged)
Where did you the LUCI builds shown https://ci.chromium.org/p/chromium/g/main/console ?
(screenshot would be nice)

To my best knowledge it still shows only buildbot ones, but it's possible we've messed something up.
Cc: jchin...@chromium.org
+jchinlee@ who is currently in early stages of migrating builder to LUCI.
IIUC this is just in the console header. The builder is not fully migrated yet; perhaps it'd be less confusing to remove the builder from the header. I'll put something together for that.
Cc: no...@chromium.org
Labels: -Pri-3 Pri-1
Owner: jchin...@chromium.org
Status: Assigned (was: Unconfirmed)
+nodir@

Oh, I didn't think about the header. Good point - I think header should use the same logic as console column to display latest prod build from whichever builders are configured for it.

Pri1 because this is blocking migrations.

Comment 7 by no...@chromium.org, Dec 21 2017

Cc: iannucci@chromium.org
the problem seems to be stemming from the fact that we are using def.Builders instead of def.Def.Builders in https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/milo/buildsource/console.go?q=console.go+&sq=package:chromium&l=167
and thus flatten the list of builder ids (we should not)

I believe +iannucci has most context

Comment 8 by mek@chromium.org, Dec 22 2017

Labels: -Sheriff-Chromium
Removing from sheriff-queue, as I don't think there is anything for sheriffs to do here.

Comment 9 by efoo@chromium.org, Dec 22 2017

Labels: LUCI-Blocker-M4 LUCI-M0-Backlog
When I filed the bug, both luci and buildbot builds were shown in the chromium.win/debug/builder/32 column, which was quite confusing as successful and non successful builds alternated. 
Now only the header seems to be affected.

Comment 11 by efoo@chromium.org, Jan 25 2018

Labels: luci-blocker-migration

Comment 12 by efoo@chromium.org, Jan 25 2018

Mergedinto: 799677
Status: Duplicate (was: Assigned)
Marked as dup

Comment 13 by efoo@chromium.org, Jan 25 2018

Labels: -LUCI-Blocker-M4
Marked as dup

Comment 14 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Backlog

Comment 15 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M0-Backlog
Status: Available (was: Duplicate)
Not a dupe! This is specificially about the console headers, not the console view (which we don't have enough info for yet).
Labels: -LUCI-Backlog LUCI-Migration
Labels: -luci-blocker-migration
Owner: iannucci@chromium.org
Status: Assigned (was: Available)
So what's happening is that the console header-rendering code operates differently from the console rendering code. It should be pretty easy to make them behave identically.

Comment 20 by efoo@chromium.org, Feb 13 2018

Cc: -jchin...@chromium.org -iannucci@chromium.org -tandrii@chromium.org -no...@chromium.org
Labels: -LUCI-Migration LUCI-Chromium-CQSets
Status: Fixed (was: Assigned)
We have been looking at this actively and have seen this recently. dullweber@chromium.org if you see this again, please let us know. 

Sign in to add a comment