New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795721 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add tooltip text to progress bar notification

Project Member Reported by mmanchala@chromium.org, Dec 18 2017

Issue description

Chrome Version: 65.0.3297.0/10225.0.0 dev-channel Gnawty,Peach Pit and Cyan
OS: Chrome

Sample URL : http://www.sample-videos.com/

What steps will reproduce the problem?
(1)Sign in to user ->Now go to above URL -> download any 30 mb file
(2)Now at Notifications ->Observe 'Downloading Sample video_1280*720_30m....' is seen in Expand and Collapse form and unable to identify Format(like .mp4,flv,mkv)(Please refer video & screenshot)

Note : If 'Downloading Sample video_1280*720_30m....' is intended change then Tool tip should be seen on hovering mouse at Notification in Expand and Collapse form 

Expected: 
a)'Downloading Sample video_1280*720_30mb.mp4' should be seen i.e.  complete text should be seen in Expand and Collapse form so that it is easy to find File Format
Actual: Instead 'Downloading Sample video_1280*720_30m....' is seen and it is unable to identify File Format

This is Regression Issue seen as same is working fine in 64.0.3282.24/10176.13.0 dev-channel Cyan i.e. entire Notification is seen

@tetsui: Please confirm the Issue
 
Actual_Notification.webm
2.0 MB View Download
Actual_Notification.jpg
374 KB View Download
Expected_Notification.webm
714 KB View Download
Expected_Notification.jpg
143 KB View Download

Comment 1 by tetsui@chromium.org, Dec 19 2017

Cc: sgabr...@chromium.org
Status: WontFix (was: Assigned)
This is a result of  https://crbug.com/789924  fix, so WAI.
+sgabriel@ to confirm
Status: Assigned (was: WontFix)
@tetsui: 

(1)If 'Downloading Sample video_1280*720_30m....' is intended change then Tool tip should be seen on hovering mouse at Notification in Expand and Collapse form , because to know which file format is getting downloaded need to wait until files gets downloaded
(2)'Downloading Sample video_1280*720_30mb.mp4' should be seen i.e.  complete text should be seen in 
'Expand form' so that it is easy to find File Format
(3)On Downloading any 30 mb file -> At Notifications observe 'Downloading Sample video_1280*720_30m....' is seen in 'Expand and Collapse' form and unable to identify Format(like .mp4,flv,mkv), need to wait until files gets downloaded
(4)Able to reproduce the issue on latest M-66.

Re-opening for tool tip behavior confirmation. Please close if this is also WAI.
Attaching Screenshot for reference

Thanks..!!


Actual_Notification.webm
2.0 MB View Download
Actual_Notification.jpg
374 KB View Download
Expected_Notification.jpg
143 KB View Download
Expected_Notification.webm
714 KB View Download
Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression -M-65 Pri-3 Type-Bug
Summary: Add tooltip text to progress bar notification (was: Regression : Unable to identify File Format(like .mp4,flv,mkv)from Downloading Notifications)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ac4d849fefccc9f4c310f59b796baabf5dd310a

commit 5ac4d849fefccc9f4c310f59b796baabf5dd310a
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Feb 08 00:53:17 2018

Use custom Layout() for CompactTitleMessageView.

CompactTitleMessageView is a view that shows the title an the message in
one line on a notification. The view is used when the notification has a
progress bar.

To fit the title and the message in one line, the view elides the texts.
(See the comment for the detail.) To accomplish this, previously it was
manually eliding the texts in OnPaint and overwriting these labels using
FillLayout. However, it has some shortcomings.
* It is not the encouraged way to implement special layout.
* Some accessibility features like tooltip doesn't work by default.

This CL does not change the basic behavior, but uses Layout() override
to achieve the special layout.

TEST=manual
BUG= 795721 

Change-Id: I9866fe589cf93781a8bb2426fc4704da48080d72
Reviewed-on: https://chromium-review.googlesource.com/906085
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535224}
[modify] https://crrev.com/5ac4d849fefccc9f4c310f59b796baabf5dd310a/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/5ac4d849fefccc9f4c310f59b796baabf5dd310a/ui/message_center/views/notification_view_md.h

Status: Fixed (was: Started)

Sign in to add a comment