VrShellControllerInputTest#testControllerScrolling failing on chromium.android/Nougat Phone Tester |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of gsennton@google.com VrShellControllerInputTest#testControllerScrolling which is part of the test suite chrome_public_test_vr_apk-pixelxl-ddview-nougat on Android failing on chromium.android/Nougat Phone Tester Builders failed on: - Nougat Phone Tester: https://build.chromium.org/p/chromium.android/builders/Nougat%20Phone%20Tester The builder has been red since build nr. 2060: https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/2060 but VrShellControllerInputTest#testControllerScrolling started failing at build nr. 2061: https://uberchromegw.corp.google.com/i/chromium.android/builders/Nougat%20Phone%20Tester/builds/2061
,
Dec 18 2017
Right, I've tried to run the test using the command bin/run_chrome_public_test_vr_apk -f VrShellControllerInputTest#testControllerScrolling but the test is being skipped. Assigning this to bsheedy@ as I don't know how to run these tests.
,
Dec 18 2017
Taking a look now. This particular test only runs on Pixel devices, and requires passing a few extra arguments to the test runner to set VR up properly.
,
Dec 18 2017
Starting a bisect now to be sure, but https://chromium-review.googlesource.com/c/chromium/src/+/664258 looks the most suspicious.
,
Dec 18 2017
That CL is the cause, but the author believes the failure is because the test needs to be updated to work with the newer logic, not because there's something wrong with their CL. They're taking a look now.
,
Dec 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1905451c0176c3a456bf290839915a8d38ae37d1 commit 1905451c0176c3a456bf290839915a8d38ae37d1 Author: bsheedy <bsheedy@chromium.org> Date: Sat Dec 23 00:26:26 2017 Remove failing scroll DCHECK for VR https://chromium-review.googlesource.com/c/chromium/src/+/842707 was supposed to fix all the crashes/test failures for VR scrolling, but there appears to be one DCHECK that is still regularly getting hit. There's probably a better long-term solution, but for now, simply remove the DCHECK. TBR: tdresser@chromium.org, sahel@chromium.org Bug: 795720 Change-Id: Icdbc4f26b5ff0bc48d9dbd05aced0008cbbc1c32 Reviewed-on: https://chromium-review.googlesource.com/843463 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526106} [modify] https://crrev.com/1905451c0176c3a456bf290839915a8d38ae37d1/ui/events/blink/input_handler_proxy.cc
,
Jan 2 2018
Closing this since the issue has been fixed and the bot is green again.
,
Mar 1 2018
,
Aug 29
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gsennton@chromium.org
, Dec 18 2017Owner: gsennton@chromium.org