AttachinG Expected Video for reference

Deleted: Expected_EULANavigation.mp4 6.8 MB

	Expected_EULANavigation.mp4 6.8 MB View Download

@alemate: Please confirm the issue

I think this is fixed in  issue 795715  .
Could you verify that it is still happening?

C#3>

Checked issue on latest M-66 66.0.3329.0/10358.0.0 dev-channel and on latest dev branch build M-65  65.0.3325.35/10323.9.0.Able to reproduce the issue.
Attaching video for reference

Deleted: OnBuildM-66.mp4 13.7 MB

	OnBuildM-66.mp4 13.7 MB View Download

Steven, could you take a look at this?

IIRC this is somewhat by design - we only auto advance the 'Connect to network' screen when a selected network connects, not when any network connects. We could change the behavior when 'Join W-Fi...' is selected such that any WiFi conneciton auto advances.

Definitely not a P1 since advancing still works, it's just not automatic.

I don't understand what's happening here.
And I cannot reproduce that. With some arbitrary WPA network I tried.

On the other hand, I believe that network should stay "selected" once you click on it. I.e. it should stay "selected" while connecting and after that. But for some reason it doesn't happen.

Is there anything special with your device? Or network? Are you using internal WiFi adapter? Is Ethernet connected at the same time?

C#7>

Repro Steps:
Select required Wi-Fi network -> 'Join Wi-Fi network' overlay is seen and enter correct password  -> Now 'Connecting...' is seen at Wi-Fi network -> After network is connected -> observe automatic navigating to EULA screen is not seen
(Please refer video)

Expected: After Wi-Fi gets connected in 'Connect to network' screen automatically navigation to EULA screen should be seen
Actual: Instead automatic navigation to EULA screen is not seen , we need to click on 'Next' to navigate to EULA screen

Able to repro issue on all devices and also issue is seen on latest M-66 build i.e. on  66.0.3344.0//10399.0.0 

Able to reproduce the issue on Chrome 66.0.3344.0//10397.0.0 - Kip.

Case 1: 
Try to connect to "GoogleGuest or GoogleGuest-Legacy ". After Wi-Fi is connected, EULA screen appears automatically.  This is expected behavior. 

Case 2: 
Try to connect wi-fi to "GIN-2g" or "GIN-3". After Wi-Fi is connected, EULA screen doesn't appear automatically.
Steps :
1. click on "GIN-2g", then "Join Wi-fi network" dialog box appears 
2. enter password and click "CONNECT" button (find the password from https://valentine.corp.google.com )
Then, after connecting the network, the screen stays on 'Connect to network'. It doesn't navigate to EULA screen automatically. 

The issue happens when connecting wi-fi through "Join Wi-fi network" dialog box.
 

Thanks for the detaile repro.
1. This problem exists in the old and new config UI if Ethernet is connected.
2. This problem exists only in the new config UI if Ethernet is not connected.

I will look into this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/240d9b2d9353eeceb21006da864011bf475e8a6b

commit 240d9b2d9353eeceb21006da864011bf475e8a6b
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Feb 14 22:15:52 2018

Network config: Fix CreateConfiguration for visible network

This CL:
* Fixes an issue where configuring a new (unsaved) visible
  network with an existing GUID would change the network's id.
* Changes cr-network-select-item to fire an event any time a
  network's connection state changes (not just on connect).
  This turned out to be not necessary but is more genrally
  useful and makes the code a bit more clear.
* Fixes the logic in cr-network-select to allow all connection
  state changes to pass through to the OOBE UI, and to correnctly
  fire events whenever the default network conneciton state
  changes.
* Correctly identifies the "default" network when Ethernet is
  in a connecting state (edge case).

Bug:  795719 

Fix CreateConfiguration for visible network

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1f6ecb682bd937549f95a3dbf9264146866f54c9
Reviewed-on: https://chromium-review.googlesource.com/917532
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536843}
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/chromeos/network/managed_network_configuration_handler_impl.cc
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/chromeos/network/network_util.cc
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/chromeos/network/network_util.h
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.js
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.html
[modify] https://crrev.com/240d9b2d9353eeceb21006da864011bf475e8a6b/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js

[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

The fix for this was kind of complicated and it is related to a bunch of other fixes. I don't think we want to try to merge them all to 65. None of them are super critical. It is still possible to advance the screen by clicking 'next'.

Checked on latest 67.0.03376.0/10518.0.0 dev-channel Reks, issue is working fine.
Will check on M-66 once the Fix is merged there