New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795718 link

Starred by 5 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
dsunk...@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
harpreet@chromium.org
steve...@chromium.org
█ bhthompson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'CONNECT' button is still seen disabled even after entering requires characters for password in 'Join Wi-Fi network' overlay

Project Member Reported by mmanchala@chromium.org, Dec 18 2017 
Chrome Version: 65.0.3297.0/10225.0.0 dev-channel Gnawty,Peach Pit and Cyan
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> 'Join Wi-Fi network' overlay is seen and enter correct password  -> observe 'CONNECT' button is still seen disabled (Please refer video)

Expected: 'CONNECT' button should be enabled even after entering required characters for Password
Actual: Instead 'CONNECT' button is still seen disabled even after entering password and 'CONNECT' button is enabled after clicking 'Enter' button from Keyboard

This is Regression Issue as same is working fine in 65.0.3294.0/10216.0.0 dev-channel Gnawty
Actual_DisabledConnectButton.mp4
15.2 MB Download

Comment 1 by mmanchala@chromium.org, Dec 18 2017 

Attaching Expected Video for reference
Expected_EnabledConnectButton.mp4
10.8 MB View Download

Comment 2 by mmanchala@chromium.org, Dec 18 2017

Cc: alemate@chromium.org

Comment 3 by mmanchala@chromium.org, Dec 19 2017

Components: UI>Shell>Networking
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
@stevenjb: Please confirm the issue

Comment 4 by steve...@chromium.org, Jan 18 2018

Cc: steve...@chromium.org tbuck...@chromium.org
 Issue 796947  has been merged into this issue.

Comment 5 by steve...@chromium.org, Jan 19 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02c820b848e1ea34d82084518fe1ccce51c290

commit cb02c820b848e1ea34d82084518fe1ccce51c290
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 19 18:15:02 2018

Fix network config focus issues

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

Bug:  795718 , 797891 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530564}
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02c820b848e1ea34d82084518fe1ccce51c290

commit cb02c820b848e1ea34d82084518fe1ccce51c290
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 19 18:15:02 2018

Fix network config focus issues

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

Bug:  795718 , 797891 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530564}
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config_input.html

Comment 8 by steve...@chromium.org, Jan 19 2018

Status: Fixed (was: Started)
Project Member

Comment 9 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jan 19 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 10 by steve...@chromium.org, Jan 23 2018

Labels: -Merge-TBD Merge-Request-65

Comment 11 by steve...@chromium.org, Jan 23 2018

Cc: bhthompson@chromium.org
Merge request ping; I have a handful of network config merge requests which need to land in order; this is the first of them.

Comment 12 by bhthompson@google.com, Jan 23 2018

Labels: -Merge-Request-65 Merge-Approved-65
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 23 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c9b21327ccd96f86a50456e9e72ce43aaee244

commit 14c9b21327ccd96f86a50456e9e72ce43aaee244
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 23 22:54:20 2018

Fix network config focus issues

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

TBR=stevenjb@chromium.org

(cherry picked from commit cb02c820b848e1ea34d82084518fe1ccce51c290)

Bug:  795718 , 797891 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530564}
Reviewed-on: https://chromium-review.googlesource.com/882185
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#41}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/network/network_state.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/network/network_state.h
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/ui/webui/resources/cr_components/chromeos/network/network_config_input.html

Comment 14 by steve...@chromium.org, Jan 23 2018

Cc: harpreet@chromium.org dsunk...@chromium.org
 Issue 805159  has been merged into this issue.

Comment 15 by mikelawther@chromium.org, Jan 29 2018 

 Issue 806626  has been merged into this issue.
►

Sign in to add a comment