New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795717 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Translate' button is not seen properly on translate bubble.

Reported by db...@etouch.net, Dec 18 2017

Issue description

Chrome Version: 65.0.3298.0 Revision 6586a208880a70a00856529493741971ecfea5c2-refs/heads/master@{#524617}(32/64 bit)
OS: Windows(7,8,10), Liunx(14.1LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to https://www.google.com/intl/en/chrome/browser/welcome.html
(2) Right click on page and select 'Translate this page' option.
(3) Then click on More option on translate bubble and change the translation language(eg.Hindi)
(4) Observe Translate button on Bubble.

Actual: 'Translate' button is not seen properly on translate bubble.

Expected: 'Translate' button should seen properly on translate bubble.
 
This is a regression issue, broken in 'M65', below is bisect info:

Good Build:64.0.3282.0
Bad Build: 65.0.32983.0

You are probably looking for a change made after 521020 (known good), but no later than 521021 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/d00d41de963ebbfcaa000768b6
d0205111124fd3..81f4f4b352ff2b7109c3bc631747219fb1dd4617

Suspect: https://chromium.googlesource.com/chromium/src/+/81f4f4b352ff2b7109c3bc631747219fb1dd4617

Note: Issue is not seen on Mac OS.
 
Actual_Translate.mp4
384 KB View Download
Expected_Translate.mp4
233 KB View Download

Comment 1 by db...@etouch.net, Dec 18 2017

Labels: -65 -hasBiscet-per-revision hasbisect-per-revision M-65
Correction in bisect builds:
----------------------------
Good Build:64.0.3282.0
Bad Build: 65.0.3283.0
Labels: ReleaseBlock-Stable
Adding Release blocker for this issue.Please remove if not the case.

Thank You!

Comment 4 by bsep@chromium.org, Dec 19 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92c6cf434530334ef73f519cf6b017d16efb5e9

commit a92c6cf434530334ef73f519cf6b017d16efb5e9
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Dec 21 20:22:08 2017

Fix "Translate" button being too small when text changes from "Done."

A re-layout of its container is required when the label changes.

Bug:  795717 
Change-Id: I42bfd7ceab36a205ff88a4cf74f82cffaaa17407
Reviewed-on: https://chromium-review.googlesource.com/838410
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525785}
[modify] https://crrev.com/a92c6cf434530334ef73f519cf6b017d16efb5e9/chrome/browser/ui/views/translate/translate_bubble_view.cc

Comment 6 by bsep@chromium.org, Dec 22 2017

Status: Fixed (was: Started)

Comment 7 by db...@etouch.net, Jan 2 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Update : 
Retested above issue on Windows(7,8,10) and Linux(14.04 LTS) OS using latest Canary #65.0.3309.0 and issue is fixed.



Thank you!

Sign in to add a comment