New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795715 link

Starred by 5 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
aashuto...@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
harpreet@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Join Wi-Fi network' overlay is not getting closed even after connecting to Network in OOBE screen

Project Member Reported by mmanchala@chromium.org, Dec 18 2017 
Chrome Version: 65.0.3297.0/10225.0.0 dev-channel Gnawty
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> 'Join Wi-Fi network' overlay is seen and enter correct password  -> observe 'Connecting' text is seen and overlay does not get closed even after connecting to Network (Please refer video)
(3)Now close 'Join Wi-Fi network' overlay and click on connected Network and observe EULA screen is not seen

Expected: 
a)After step (2) 'Join Wi-Fi network' overlay should get close automatically 
b)On clicking connected Wi-Fi Network EULA screen should be seen

Actual: Instead
a)'Join Wi-Fi network' overlay does not get closed even after connecting to Network
b)On clicking connected Wi-Fi Network EULA screen is not seen

Note : Issue is seen on Gnawty device only

This is Regression Issue as same is working fine in 65.0.3294.0/10216.0.0 dev-channel Gnawty
Actual_OverlayIsNotGettingClosed.mp4
17.4 MB Download

Comment 1 by steve...@chromium.org, Dec 18 2017

Components: UI>Shell>Networking
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by steve...@chromium.org, Dec 18 2017

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Not blocking anything, just a bit confusing, RBB -> RBS.

Comment 3 by steve...@chromium.org, Jan 17 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5cc0bd71de6ddf7286b3dc90e65b621786a7372

commit a5cc0bd71de6ddf7286b3dc90e65b621786a7372
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 19 23:48:53 2018

NetworkConnectionHandler::ConnectToNetwork: support immediate succeed

This adds a parameter to ConnectToNetwork 'succeed_on_send_connect'.
If set, ConnectToNetwork will call the 'success' callback as soon as
a connect request is sent to Shill (if there were no configuration
errors) instead of after the connect succeeds.

This is used by the networkingPrivate implementation to more correctly
implement the API.

This CL causes the Settings based network config UI to close its dialog
when the connection starts.

Bug:  795715 
For minor changes to comonents/arc/net:
TBR=hidehiko@chromium.org

Change-Id: I5de65a32a46d57dc628c65542a275505d4d7c944
Reviewed-on: https://chromium-review.googlesource.com/875002
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530661}
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chrome/browser/ui/ash/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/components/tether/wifi_hotspot_disconnector_impl_unittest.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/network/auto_connect_handler_unittest.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/network/network_connect.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/network/network_connection_handler.h
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/chromeos/network/network_connection_handler_impl_unittest.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/extensions/common/api/networking_private.idl
[modify] https://crrev.com/a5cc0bd71de6ddf7286b3dc90e65b621786a7372/extensions/shell/browser/shell_network_controller_chromeos.cc

Comment 5 by harpreet@chromium.org, Jan 22 2018

Cc: harpreet@chromium.org aashuto...@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9bc09db743ae84586879f1b7d2e235efaab347d

commit a9bc09db743ae84586879f1b7d2e235efaab347d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 22 20:13:06 2018

Fix network config UI

This CL cleans up the network config UI to improve the display
of 'Connecting' and improve error handling and display.

Bug:  795715 ,  795698 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f2dc1654c29524e5b7ae99cfbe43692a9fdb470
Reviewed-on: https://chromium-review.googlesource.com/874605
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530967}
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chrome/browser/chromeos/net/shill_error.cc
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chromeos/network/network_configuration_handler.h
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/ui/webui/resources/cr_components/chromeos/network/network_config.js

Comment 7 by steve...@chromium.org, Jan 22 2018

Status: Fixed (was: Started)

Comment 8 by steve...@chromium.org, Jan 22 2018

Labels: Merge-Request-65

Comment 9 by bhthompson@google.com, Jan 23 2018

Labels: -Merge-Request-65 Merge-Approved-65
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 23 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29fa3fcb5e65ac3985d2093bc11f372081ced1e0

commit 29fa3fcb5e65ac3985d2093bc11f372081ced1e0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 23 22:56:12 2018

NetworkConnectionHandler::ConnectToNetwork: support immediate succeed

This adds a parameter to ConnectToNetwork 'succeed_on_send_connect'.
If set, ConnectToNetwork will call the 'success' callback as soon as
a connect request is sent to Shill (if there were no configuration
errors) instead of after the connect succeeds.

This is used by the networkingPrivate implementation to more correctly
implement the API.

This CL causes the Settings based network config UI to close its dialog
when the connection starts.

Bug:  795715 
For minor changes to comonents/arc/net:
TBR=hidehiko@chromium.org, stevenjb@chromium.org

(cherry picked from commit a5cc0bd71de6ddf7286b3dc90e65b621786a7372)

Change-Id: I5de65a32a46d57dc628c65542a275505d4d7c944
Reviewed-on: https://chromium-review.googlesource.com/875002
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530661}
Reviewed-on: https://chromium-review.googlesource.com/882306
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#42}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chrome/browser/ui/ash/auto_connect_notifier_unittest.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/components/tether/wifi_hotspot_disconnector_impl_unittest.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/network/auto_connect_handler_unittest.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/network/network_connect.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/network/network_connection_handler.h
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/chromeos/network/network_connection_handler_impl_unittest.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/extensions/common/api/networking_private.idl
[modify] https://crrev.com/29fa3fcb5e65ac3985d2093bc11f372081ced1e0/extensions/shell/browser/shell_network_controller_chromeos.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a5646ee3ab8887eddef734ef87ed808d9d3793f

commit 4a5646ee3ab8887eddef734ef87ed808d9d3793f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 24 00:32:06 2018

Fix network config UI

This CL cleans up the network config UI to improve the display
of 'Connecting' and improve error handling and display.

TBR=stevenjb@chromium.org

(cherry picked from commit a9bc09db743ae84586879f1b7d2e235efaab347d)

Bug:  795715 ,  795698 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f2dc1654c29524e5b7ae99cfbe43692a9fdb470
Reviewed-on: https://chromium-review.googlesource.com/874605
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530967}
Reviewed-on: https://chromium-review.googlesource.com/882550
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#51}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chrome/browser/chromeos/net/shill_error.cc
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chromeos/network/network_configuration_handler.cc
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chromeos/network/network_configuration_handler.h
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/ui/webui/resources/cr_components/chromeos/network/network_config.js

Comment 12 by steve...@chromium.org, Jan 25 2018 

Issue 799618 has been merged into this issue.
►

Sign in to add a comment