New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795708 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 624061



Sign in to add a comment

Apply User Study findings to blocked redirection infobar

Project Member Reported by dgn@chromium.org, Dec 18 2017

Issue description

Quoting hwi@:

- Change the title to “Redirect blocked to site:” (expanded view only)
- Change the button label to “GOT IT”
- Change the icon on Android to the chrome icon, and delete the current icon file from the code base.
 

Comment 1 by dgn@chromium.org, Dec 18 2017

New UX preview
Screenshot_2017-12-18-14-30-43.png
242 KB View Download
Screenshot_2017-12-18-16-31-46.png
218 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f3a7db83ba6b0b60adf951fbe62e7a3a6282834

commit 6f3a7db83ba6b0b60adf951fbe62e7a3a6282834
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Thu Dec 21 18:21:41 2017

👮 Update Redirect Blocking Infobar UX

- Change the title of expanded infobar to "Redirect blocked to site:"
- Change the button label to "GOT IT"
- Change the icon on Android to the chrome icon, and delete the current
icon file from the code base.

Bug:  795708 
Change-Id: Ide08be320fae678f2538756e368bfa86028da5da
Reviewed-on: https://chromium-review.googlesource.com/832388
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525742}
[delete] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/chrome/android/java/res/drawable-hdpi/infobar_redirect_blocked.png
[delete] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/chrome/android/java/res/drawable-mdpi/infobar_redirect_blocked.png
[delete] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/chrome/android/java/res/drawable-xhdpi/infobar_redirect_blocked.png
[delete] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/chrome/android/java/res/drawable-xxhdpi/infobar_redirect_blocked.png
[delete] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/chrome/android/java/res/drawable-xxxhdpi/infobar_redirect_blocked.png
[modify] https://crrev.com/6f3a7db83ba6b0b60adf951fbe62e7a3a6282834/chrome/android/java/src/org/chromium/chrome/browser/infobar/FramebustBlockInfoBar.java
[modify] https://crrev.com/6f3a7db83ba6b0b60adf951fbe62e7a3a6282834/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/6f3a7db83ba6b0b60adf951fbe62e7a3a6282834/chrome/app/chromium_strings.grd
[modify] https://crrev.com/6f3a7db83ba6b0b60adf951fbe62e7a3a6282834/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/6f3a7db83ba6b0b60adf951fbe62e7a3a6282834/chrome/browser/android/resource_id.h

Comment 3 by dgn@chromium.org, Dec 21 2017

Status: Fixed (was: Started)

Comment 4 by hwi@chromium.org, Dec 21 2017

Thanks much, dgn@! 🎶 🎶 🎶

Sign in to add a comment