Issue metadata
Sign in to add a comment
|
Regression: Network status is in connecting only when wrong password is entered. |
||||||||||||||||||||||
Issue descriptionChrome Version:65.0.3297.0/10225.0.0 dev Gnawty,Cyan,Peach-Pit OS:Chrome OS What steps will reproduce the problem? (1)Recover build>> In Connect to network screen, type some random password and observe Actual: Unless we only close the password overlay, the network is still in connecting stage and No error notification is seen Expected: Error message should be seen NOTE:Only when we give a wrong password nearer to correct password, bad password message is seen This is a Regression issue as same is working fine in 65.0.3294.0/10216.0.0 dev NOTE: Issue is not seen on Windows and Linux
,
Dec 18 2017
Not blocking connecting so no need for this to be RBD.
,
Jan 18 2018
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9bc09db743ae84586879f1b7d2e235efaab347d commit a9bc09db743ae84586879f1b7d2e235efaab347d Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jan 22 20:13:06 2018 Fix network config UI This CL cleans up the network config UI to improve the display of 'Connecting' and improve error handling and display. Bug: 795715 , 795698 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2f2dc1654c29524e5b7ae99cfbe43692a9fdb470 Reviewed-on: https://chromium-review.googlesource.com/874605 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#530967} [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chrome/browser/chromeos/net/shill_error.cc [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chromeos/network/network_configuration_handler.cc [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/chromeos/network/network_configuration_handler.h [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/a9bc09db743ae84586879f1b7d2e235efaab347d/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Jan 22 2018
,
Jan 23 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a5646ee3ab8887eddef734ef87ed808d9d3793f commit 4a5646ee3ab8887eddef734ef87ed808d9d3793f Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jan 24 00:32:06 2018 Fix network config UI This CL cleans up the network config UI to improve the display of 'Connecting' and improve error handling and display. TBR=stevenjb@chromium.org (cherry picked from commit a9bc09db743ae84586879f1b7d2e235efaab347d) Bug: 795715 , 795698 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2f2dc1654c29524e5b7ae99cfbe43692a9fdb470 Reviewed-on: https://chromium-review.googlesource.com/874605 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530967} Reviewed-on: https://chromium-review.googlesource.com/882550 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#51} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chrome/browser/chromeos/net/shill_error.cc [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chromeos/network/network_configuration_handler.cc [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/chromeos/network/network_configuration_handler.h [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/4a5646ee3ab8887eddef734ef87ed808d9d3793f/ui/webui/resources/cr_components/chromeos/network/network_config.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Dec 18 2017Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)