New issue
Advanced search Search tips

Issue 795683 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Button to copy suggestion to omnibox is not present on iPhone X landscape

Project Member Reported by gambard@chromium.org, Dec 18 2017

Issue description

Chrome Version: iOS 11
iPhone X only

What steps will reproduce the problem?
(1) Tap on the omnibox and type something such as there are suggestions with a little arrow (allowing the user to copy the text in the omnibox)
(2) Rotate to landscape

What is the expected result?
The arrow should be displayed.

What happens instead?
No arrow. It also happen with the phone directly on landscape (i.e. no need to rotate).
 
Labels: M-65
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ac44846b4859eb967b83b14c7abb64715ebaf5e

commit 9ac44846b4859eb967b83b14c7abb64715ebaf5e
Author: Justin Cohen <justincohen@google.com>
Date: Thu Jan 04 04:47:41 2018

[ios] Fix accessory view layout for omnibox popup

Bug:  795683 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iab78eeda08a1de8a56a662f8a0b2b4d4fe8696da
Reviewed-on: https://chromium-review.googlesource.com/847429
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526922}
[modify] https://crrev.com/9ac44846b4859eb967b83b14c7abb64715ebaf5e/ios/chrome/browser/ui/omnibox/omnibox_popup_row.mm

Status: Fixed (was: Started)
Cc: srikanthg@chromium.org
Status: Verified (was: Fixed)
Verified on M65.0.3315.0 canary
Device: iPhoneX
iOS: 11.2.5

Append query icon is displayed correctly in both portrait and landscape modes.
Also after device rotation.

I see a misalignment with omnibox suggestions in RTL mode. Will create a new bug for this case.
http://crbug/799972 is reported for RTL issue.

Sign in to add a comment