New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Stack sampling profiler: profiling the IO thread

Project Member Reported by chengx@chromium.org, Dec 18 2017

Issue description

We have enabled profiling the main thread of the browser process using stack sampling profiler. We should enable this for IO thread as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2018

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c965371abdc7377fb01048959b75383f83c97d2

commit 8c965371abdc7377fb01048959b75383f83c97d2
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Jan 24 06:07:27 2018

Enable sampling profiler for IO thread of browser process at startup

Bug:  795672 
Change-Id: If2ae7ff68ab36a2987c2c4462a3c1dc092c20989
Reviewed-on: https://chromium-review.googlesource.com/851427
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531453}
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/base/profiler/stack_sampling_profiler.cc
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/base/profiler/stack_sampling_profiler.h
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/chrome/browser/chrome_browser_main.h
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/chrome/common/stack_sampling_configuration.h
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/components/metrics/call_stack_profile_metrics_provider.cc
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/components/metrics/call_stack_profile_metrics_provider.h
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/content/browser/browser_main_loop.cc
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/content/browser/browser_main_loop.h
[modify] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/content/public/browser/browser_main_parts.h

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb2fc55e5f91c8f956ebf7bd9439c1a3b44fb96

commit 8cb2fc55e5f91c8f956ebf7bd9439c1a3b44fb96
Author: chengx <chengx@chromium.org>
Date: Thu Feb 01 03:14:10 2018

Enable periodic sampling for the IO thread of browser process

Bug:  795672 
Change-Id: Icd947146950422f919583b700e6df5660cadc920
Reviewed-on: https://chromium-review.googlesource.com/857260
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533541}
[modify] https://crrev.com/8cb2fc55e5f91c8f956ebf7bd9439c1a3b44fb96/components/metrics/call_stack_profile_metrics_provider.cc

Cc: -wittman@chromium.org chengx@chromium.org
Owner: wittman@chromium.org
I have an implementation for the renderer process IO thread, so I will take this for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1419ff55f942cd2073b35268a737bdf4b0cb267

commit c1419ff55f942cd2073b35268a737bdf4b0cb267
Author: Mike Wittman <wittman@chromium.org>
Date: Fri Mar 02 23:50:04 2018

Sampling profiler: profile the renderer IO thread

Execution profiles of the IO thread in the browser and GPU processes is
in place. This change extends profiling to the IO thread in the renderer
process.


Bug:  795672 
Change-Id: I11a79822713486ae4f26b34fe733121164322655
Reviewed-on: https://chromium-review.googlesource.com/946648
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540685}
[modify] https://crrev.com/c1419ff55f942cd2073b35268a737bdf4b0cb267/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/c1419ff55f942cd2073b35268a737bdf4b0cb267/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/c1419ff55f942cd2073b35268a737bdf4b0cb267/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/c1419ff55f942cd2073b35268a737bdf4b0cb267/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/c1419ff55f942cd2073b35268a737bdf4b0cb267/content/renderer/render_thread_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment