New issue
Advanced search Search tips

Issue 795669 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

UIImageWithSizeAndSolidColor should allow to specify the image scale

Project Member Reported by sdefresne@chromium.org, Dec 18 2017 
UIImageWithSizeAndSolidColor always generate an image with a scale of 1.0 and UIImagesAreEqual fails if the image have different scale, thus making it hard to use them to compare expected images if the process generating the image use another scale.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e159182eccee48ad436defc6360e6f4518a3af3a

commit e159182eccee48ad436defc6360e6f4518a3af3a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Dec 18 10:36:14 2017

Add function to create image with size, color and scale.

Some tests needs to create an image with a given scale, so add
a function with a scale parameter.

Bug:  795669 
Change-Id: Ibdc6863a247c2035cbbd5fed64c5b0954cbb2327
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/831514
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524671}
[modify] https://crrev.com/e159182eccee48ad436defc6360e6f4518a3af3a/ui/base/test/ios/ui_image_test_utils.h
[modify] https://crrev.com/e159182eccee48ad436defc6360e6f4518a3af3a/ui/base/test/ios/ui_image_test_utils.mm

Comment 2 by sdefresne@chromium.org, Dec 18 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment