Issue metadata
Sign in to add a comment
|
PrintPreviewUIBrowserTest.WinSystemDialogLink in browser_tests failing on chromium.win/Win7 Tests (dbg)(1) |
||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nhiroki@google.com PrintPreviewUIBrowserTest.WinSystemDialogLink in browser_tests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29
,
Dec 18 2017
Regression range: https://chromium.googlesource.com/chromium/src/+log/249dc2fe982d665760b5acfafb6b9eb62d0acd1f%5E..5ef28a71a39d342df6df9f4fcc8c1b790b5d46e3?pretty=fuller&n= These CLs are suspicious: - "Use the PDF in PrintPreviewDataStore for local printers" https://chromium-review.googlesource.com/704262 - "Print Preview Componentization: Use destination updates" https://chromium-review.googlesource.com/823579 +rbpotter@ who is the author of these CLs.
,
Dec 18 2017
Only one test is failing, so I'll disable it instead of reverting the CLs...
,
Dec 18 2017
,
Dec 18 2017
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/642ce9b06d3a1d79b7fc877075f23b12c941ea30 commit 642ce9b06d3a1d79b7fc877075f23b12c941ea30 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Dec 18 09:21:28 2017 Disable PrintPreviewUIBrowserTest.WinSystemDialogLink Bug: 795658 Change-Id: Idb8f12e4d8c4fc738d425fd516231cfdcddbd8b3 TBR: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/831319 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524665} [modify] https://crrev.com/642ce9b06d3a1d79b7fc877075f23b12c941ea30/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6 commit e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6 Author: rbpotter <rbpotter@chromium.org> Date: Wed Dec 20 18:49:49 2017 Print Preview: Fix tests Tests were failing due to setTimeout() in preview area expiring after dialog was closed. Cancel the timeout in exitDocument() to prevent this and re-enable tests. Bug: 795626 , 795658 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie569c9509b459dadcf3c6aefba7de7624ca363de Reviewed-on: https://chromium-review.googlesource.com/833496 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#525386} [modify] https://crrev.com/e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6/chrome/browser/resources/print_preview/previewarea/preview_area.js [modify] https://crrev.com/e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
,
Dec 21 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by nhiroki@chromium.org
, Dec 18 2017Labels: OS-Windows Type-Bug-Regression