New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 795656 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus ring is seen on first radio button even after clicking on second radio button.

Reported by vku...@etouch.net, Dec 18 2017 
Chrome Version: 65.0.3297.0 (Official Build) d046a9d9f3ca30d1d00c0bba152668e70d86d385-refs/heads/master@{#524606} (32/64 Bit)
OS:Windows (7,8,8.1,10),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://permission.site/ ,click on https
(2)Click on 'microphone' button, click on bubble and press tab key such that focus appears on radio button.
(3)Now click on second radio button and observe.

Actual: Focus ring is seen on first radio button even after clicking on second radio button.

Expected: Focus ring should be seen on second radio button after clicking on it.
 
This is a regression issue broken in 'M65' and will soon update other info.
Actual_Focus.mp4
470 KB View Download

Comment 1 by vku...@etouch.net, Dec 18 2017

Labels: hasbisect-per-revision OS-Linux
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Correction:
This is a regression issue broken in 'M61' and below is the manual bisect info
Good Build: 61.0.3142.0
Bad Build:  61.0.3143.0 

You are probably looking for a change made after 482734 (known good), but no later than 482735 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/28347e73895e16a6eb7b512d1b7e96f39bab9a75..a3fb693eb7384259d24c3f5f3835c428860aa6f6

Suspecting: https://chromium.googlesource.com/chromium/src/+/a3fb693eb7384259d24c3f5f3835c428860aa6f6
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Above issue is seen on latest M64 branch build 64.0.3282.32 and on latest canary 65.0.3298.0 (Official Build)
Expected_Focus.mp4
294 KB View Download

Comment 2 by bsep@chromium.org, Jan 2 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33bd85d9705a40b4da795d400837134f6a81aff1

commit 33bd85d9705a40b4da795d400837134f6a81aff1
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jan 05 04:30:13 2018

Fix radio buttons not taking focus from other buttons in the group.

Radio buttons shouldn't take focus when clicked. But if another radio
button in the group has focus it looks wrong to not take the focus from
it, because the selection and focus don't match any more. So now we take
focus only if the focus is already in the group.

Bug:  795656 
Change-Id: If0b69d61842208d57ad00761ce3dd4d2cffad752
Reviewed-on: https://chromium-review.googlesource.com/848232
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527204}
[modify] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/ui/views/controls/button/button.cc
[modify] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/ui/views/controls/button/button.h
[modify] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/ui/views/controls/button/radio_button.h
[modify] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/ui/views/controls/button/radio_button_unittest.cc

Comment 4 by bsep@chromium.org, Jan 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment