Drag Floating keyboard will feel late lag. |
||||||
Issue descriptionChrome Version: 65.0.3293.0 Kevin What steps will reproduce the problem? (1) Flash a develop version ChromeOS (2) Installs Google Input Tool floating version from gs://chromeos-localmirror-private/distfiles/input-tools-6.8.0.7.tar.gz (3) Enter floating keyboard mode. (4) Holds the candidate bar by finger to drag floating keyboards, you feel lag. What is the expected result? Drag keyboard more smoothly. What happens instead? Drag keyboard has lag.
,
Dec 18 2017
,
Dec 18 2017
More detail to repro drag bug, please enter focus into input box and input to show candidates the drag the keyboard.
,
Dec 18 2017
,
Dec 18 2017
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8813219dc9df77a88b5fbf426e53ea09275de101 commit 8813219dc9df77a88b5fbf426e53ea09275de101 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue Dec 19 04:07:19 2017 Don't call SetCaputure() when starting dragging the floating keyboard. When starting dragging, input events are already captured by the keyboard window and calling SetCaputure() cancels current capture. Bug: 795648 Test: By manual. Change-Id: Ib3e8f651a54082ebb858bc37fb870001005cbec8 Reviewed-on: https://chromium-review.googlesource.com/831772 Reviewed-by: Blake O'Hare <blakeo@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#524939} [modify] https://crrev.com/8813219dc9df77a88b5fbf426e53ea09275de101/ui/keyboard/container_floating_behavior.cc
,
Dec 19 2017
,
Dec 26 2017
The bug wasn't fixed. 1. slide on keyboard and finger enter candidate bar. 2. Then take up the finger suddenly. 3. Touch any place of screen. Then the floating keyboard is dragged to the touch point.
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9dc7440c3316198db04175cf37cc29db8950cf4 commit a9dc7440c3316198db04175cf37cc29db8950cf4 Author: Yingbing Wu <wuyingbing@chromium.org> Date: Tue Jan 09 08:24:01 2018 Polishs the dragging logic. Only allow to start dragging inside draggable area. Moves keyboard on mouse drag event or touch movement. Disables dragging when event is outside the dragging area. Bug: chromium:795648 , chromium:798965 Change-Id: I88cf365481dbb93622ad0dcdbce1e747543f86bc Reviewed-on: https://chromium-review.googlesource.com/845548 Commit-Queue: Yingbing Wu <wuyingbing@chromium.org> Reviewed-by: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#527936} [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_behavior.h [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_full_width_behavior.h [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_event_filter.cc [modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_event_filter.h
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/373a6afb7e519029f0be24b59b67baa32a689cc8 commit 373a6afb7e519029f0be24b59b67baa32a689cc8 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Fri Jan 12 08:28:40 2018 Don't stop keyboard dragging if pointer event moves to outside of the VK window. If a user drags the VK window too fast, pointer events can be fired outside of the VK window. We shouldn't stop dragging in this case if dragging is already started. Bug: 795648 Test: By manual. Dragging floating keyboard fast. Change-Id: I225b65338dc754a470a4c8d746623b1ba06ba0ca Reviewed-on: https://chromium-review.googlesource.com/861684 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#528907} [modify] https://crrev.com/373a6afb7e519029f0be24b59b67baa32a689cc8/ui/keyboard/container_floating_behavior.cc
,
Jan 12 2018
It should be fixed now. will file another bug if I see this bug again. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wuyingbing@chromium.org
, Dec 18 20173.3 MB
3.3 MB View Download