New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 795635 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Weird flickering is seen on Doodle

Reported by pranjali...@etouch.net, Dec 18 2017

Issue description

Chrome Version:65.0.3297.0 (Official Build) d046a9d9f3ca30d1d00c0bba152668e70d86d385-refs/heads/master@{#524606} 

OS:Mac(10.12.6,10.13.2)

Steps to reproduce:
1.Launch Chrome and go to NTP.
2.Click on Next slide icon on doddle and observe.

Actual Result:Weird flickering is seen on Doodle
Expected Result: Flickering should not be seen.


This is a regression issue, broken in M-65 series, will soon update other info

 
Labels: hasbisect-per-revision
Owner: junov@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build:65.0.3294.0
Bad Build:65.0.3295.0

You are probably looking for a change made after 524203 (known good), but no later than 524204 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/1e920b32c7c3000523870464e0a8954a0474790e..2e4a432454ac3f04d6c5fa8f17c49ce3026217d6

Suspect:https://chromium.googlesource.com/chromium/src/+/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6

junov@:Kindly help to reassign, if your changes are not related to this issue.

 Note:Issue is not seen on Win(7,8,10),Linux(14.04 LTS)   
Actual_result.mov
6.0 MB Download
Expected_result.mov
5.0 MB Download
Note:
Above issue is also seen on latest canary 65.0.3298.0

Comment 3 by junov@chromium.org, Dec 18 2017

Doodles change every day and vary by country.  Can you provide a URL from the doodle archive?

Comment 4 by junov@chromium.org, Dec 18 2017

Assuming it is this one: https://www.google.com/doodles/holidays-2017-day-1

Comment 5 by junov@chromium.org, Dec 18 2017

Repro confirmed. Issue appears to be mac-specific.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1fd548f2cf9a3585e82d800cfc40167a48bb582

commit c1fd548f2cf9a3585e82d800cfc40167a48bb582
Author: Justin Novosad <junov@chromium.org>
Date: Tue Dec 19 00:55:31 2017

Fix canvas flickering and broken updates on Mac

CanvasResource_GpuMemoryBuffer was not refreshing its
sync token when new content was added, resulting in recycled
buffers never getting their contents flushed.

BUG= 795635 ,  795252 
TBR=xlai@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77a9e2cdba1397a664eda1e46d9126b1e2c8114d
Reviewed-on: https://chromium-review.googlesource.com/832350
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524888}
[modify] https://crrev.com/c1fd548f2cf9a3585e82d800cfc40167a48bb582/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/c1fd548f2cf9a3585e82d800cfc40167a48bb582/third_party/WebKit/Source/platform/graphics/CanvasResource.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2017

Labels: merge-merged-3298
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59620135abb6dc7802569b3a8a7214d19657c2b1

commit 59620135abb6dc7802569b3a8a7214d19657c2b1
Author: Justin Novosad <junov@chromium.org>
Date: Tue Dec 19 01:00:21 2017

Fix canvas flickering and broken updates on Mac

CanvasResource_GpuMemoryBuffer was not refreshing its
sync token when new content was added, resulting in recycled
buffers never getting their contents flushed.

BUG= 795635 ,  795252 
TBR=junov@chromium.org, xlai@chromium.org
NOTRY=true

(cherry picked from commit c1fd548f2cf9a3585e82d800cfc40167a48bb582)

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77a9e2cdba1397a664eda1e46d9126b1e2c8114d
Reviewed-on: https://chromium-review.googlesource.com/832350
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524888}
Reviewed-on: https://chromium-review.googlesource.com/833069
Cr-Commit-Position: refs/branch-heads/3298@{#4}
Cr-Branched-From: 6586a208880a70a00856529493741971ecfea5c2-refs/heads/master@{#524617}
[modify] https://crrev.com/59620135abb6dc7802569b3a8a7214d19657c2b1/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/59620135abb6dc7802569b3a8a7214d19657c2b1/third_party/WebKit/Source/platform/graphics/CanvasResource.h

Labels: TE-Verified-M65 TE-Verified-65.0.3298.3 TE-Verified-65.0.3299.0
Rechecked the above issue on Mac(10.12.6,10,13.2) OS with latest canary chrome version :65.0.3299.0 and Dev #65.0.3298.3 and fix is working as intended.
Kindly refer the attached screen cast for reference.
Result.mov
7.0 MB Download

Comment 9 by junov@chromium.org, Jan 9 2018

Cc: jvanverth@chromium.org xidac...@chromium.org senorblanco@chromium.org egdaniel@chromium.org
 Issue 795944  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fd5440ed9a178828fcc752bc1b180c3ad715086

commit 1fd5440ed9a178828fcc752bc1b180c3ad715086
Author: Justin Novosad <junov@chromium.org>
Date: Wed Jan 10 21:14:06 2018

Add test for SyncToken updates in 2D canvas GpuMemoryBuffer code path

This change adds a test and also re-arranges the fix from previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/832350

BUG= 796079 , 795635 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iff30eeebaf72bb4dc34be0dc7bd4afc3fc2e9ced
Reviewed-on: https://chromium-review.googlesource.com/836752
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528423}
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/graphics/CanvasResource.h
[modify] https://crrev.com/1fd5440ed9a178828fcc752bc1b180c3ad715086/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a08442c76baf9fe44415a14aee1a2e7a95ae582

commit 3a08442c76baf9fe44415a14aee1a2e7a95ae582
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Wed Jan 10 23:03:21 2018

[jumbo] rename duplicate FakePlatformSupport class

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/836752
in order to un-break jumbo builds.

TBR=junov@chromium.org
BUG= 796079 , 795635 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I605b8bb07357f6aa478692ffdb6b12454b891267
Reviewed-on: https://chromium-review.googlesource.com/860923
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#528460}
[modify] https://crrev.com/3a08442c76baf9fe44415a14aee1a2e7a95ae582/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp

Labels: zine-triaged

Comment 13 by junov@chromium.org, Jan 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment