New issue
Advanced search Search tips

Issue 795627 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

V8ScriptValueSerializerForModulesTest.DecodeInvalidRTCCertificate and 2 other(s) in webkit_unit_tests failing on chromium.linux/Cast Audio Linux

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 18 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nhiroki@google.com

V8ScriptValueSerializerForModulesTest.DecodeInvalidRTCCertificate and 2 other(s) in webkit_unit_tests failing on chromium.linux/Cast Audio Linux

Builders failed on: 
- Cast Audio Linux: 
  https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux


 
Components: Blink>Bindings
Labels: Type-Bug
Sheriff-o-Matic provided the regression range:
https://chromium.googlesource.com/chromium/src/+log/312ddcdab0b16b3de40f5e198ed16fae78d709fa%5E..a7b961302726f6accc1d70682017b6c36127ae7a?pretty=fuller&n=

Looks like these tests were disabled on the bot, but enabled by this CL:
"Run the blink unit tests on the remaining main bots."
https://chromium-review.googlesource.com/c/chromium/src/+/829874
attachment.bin
21.8 KB Download
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4663eb2bb37e86efb301416834ab707aa0c8296

commit a4663eb2bb37e86efb301416834ab707aa0c8296
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 18 04:12:25 2017

Disable V8ScriptValueSerializerForModulesTest on Linux

These tests are crashing on the chromium.linux/Cast Audio Linux bot.

Bug:  795627 
Change-Id: Ifefee9f86a15a80d5fc6a455b37482dbad264bc2
TBR: haraken@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/831313
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524650}
[modify] https://crrev.com/a4663eb2bb37e86efb301416834ab707aa0c8296/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

Owner: jbroman@chromium.org
Status: Assigned (was: Available)
jbroman@: Could you take a look at this?
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a957db365602f08fc7a71cf0f954915a7dc60c57

commit a957db365602f08fc7a71cf0f954915a7dc60c57
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Dec 27 02:37:17 2017

V8ScriptValueDeserializer: Handle WebRTC being disabled.

This resolves an issue whereby unit tests would crash if the WebRTC
implementation was not available.

Bug:  795627 
Change-Id: I03352725217d6d5be34247a1aae2663157ae4292
Reviewed-on: https://chromium-review.googlesource.com/844031
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526206}
[modify] https://crrev.com/a957db365602f08fc7a71cf0f954915a7dc60c57/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueDeserializerForModules.cpp
[modify] https://crrev.com/a957db365602f08fc7a71cf0f954915a7dc60c57/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment