Issue metadata
Sign in to add a comment
|
PrintPreviewUIBrowserTest.InvalidSettingsError in browser_tests failing on chromium.mac/Mac10.9 Tests (dbg) |
||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nhiroki@google.com PrintPreviewUIBrowserTest.InvalidSettingsError in browser_tests failing on chromium.mac/Mac10.9 Tests (dbg) Builders failed on: - Mac10.9 Tests (dbg): https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29
,
Dec 18 2017
Disabling the test... https://chromium-review.googlesource.com/c/830993/
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b459327f1581343c8ca47539150370539ed4f164 commit b459327f1581343c8ca47539150370539ed4f164 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Dec 18 03:25:36 2017 Disable PrintPreviewUIBrowserTest.InvalidSettingsError because of test flakiness Bug: 795626 Change-Id: If0016e86ca495cee54bf4b7a845f5adda8e6b65b TBR: dpapad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/830993 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524647} [modify] https://crrev.com/b459327f1581343c8ca47539150370539ed4f164/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
,
Dec 18 2017
@nhiroki: Given that this test was only flaking on Mac, should it have been disabled for Mac only? It seems it was disabled entirely.
,
Dec 18 2017
@rbpotter: Looking at the error "Uncaught TypeError: Cannot read property 'classList' of null", source: chrome://print/print_preview.js (14565) It seems that in some cases the line at [1] executes either before decorateInternal(), or after exitDocument(). Maybe a race condition in the test? [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/previewarea/preview_area.js?l=438
,
Dec 18 2017
Reg c#4: Sorry, I didn't know C/C++ marco is available in the JS file.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6 commit e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6 Author: rbpotter <rbpotter@chromium.org> Date: Wed Dec 20 18:49:49 2017 Print Preview: Fix tests Tests were failing due to setTimeout() in preview area expiring after dialog was closed. Cancel the timeout in exitDocument() to prevent this and re-enable tests. Bug: 795626 , 795658 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie569c9509b459dadcf3c6aefba7de7624ca363de Reviewed-on: https://chromium-review.googlesource.com/833496 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#525386} [modify] https://crrev.com/e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6/chrome/browser/resources/print_preview/previewarea/preview_area.js [modify] https://crrev.com/e28af6a1633a2abc7e0d937d5bfc65c1032ce4e6/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
,
Dec 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nhiroki@chromium.org
, Dec 18 2017Components: UI>Browser>PrintPreview
Labels: OS-Mac Type-Bug-Regression