New issue
Advanced search Search tips

Issue 795622 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Deleted files show up while searching the Files App on ChromeOS

Project Member Reported by raymes@chromium.org, Dec 18 2017

Issue description

When searching for files in the Files App on ChromeOS, deleted files show up but there is no indication that they are deleted. This can be quite confusing depending on user expectations, e.g. I delete a file and then do a search to make sure the file is gone, but it shows up. Or if there are multiple copies of the file, some deleted and some not, it is impossible to tell which is the "live" one. 

I think there is a use case for searching for deleted files, but it should be a separate option and not the default, OR deleted files should be very clearly marked in the search results. In drive.google.com a toast is shown when you do a search which returns results for deleted files, which allows you to include them.
 
Owner: yamaguchi@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a1f0c1b78d42a5e11f8107aa4f3f80c09eb6f0

commit 77a1f0c1b78d42a5e11f8107aa4f3f80c09eb6f0
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Dec 21 07:35:49 2017

Exclude trashed items when querying files from Drive API.

Other methods in the same class, like GetFileListInDirectory() or
SearchByTitle() queries excluding trashed files. Search() should be
consistent with those.

Bug:  795622 
Test: manually tested by searching trashed files in My Drive volume
Change-Id: I3a7a11671db5d3b1866a1caa4f3582f6e6581f4b
Reviewed-on: https://chromium-review.googlesource.com/832595
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525639}
[modify] https://crrev.com/77a1f0c1b78d42a5e11f8107aa4f3f80c09eb6f0/components/drive/service/drive_api_service.cc

Status: Fixed (was: Started)
As a known issue, if user has seen trashed items once by the search before the fix, those will appear in the "recent" pseudo volume unless user removes the Drive metadata cache.
Status: Archived (was: Fixed)

Sign in to add a comment