New issue
Advanced search Search tips

Issue 795617 link

Starred by 2 users
Status: Fixed
Owner:
sahel@chromium.org
Closed: Jan 2018
Cc:
dtapu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

RenderWidgetHostViewAuraOverscroll*.ScrollEventsOverscrollWithFling and FlingControllerTest.ControllerHandlesGestureFling tests are flaky

Project Member Reported by w...@chromium.org, Dec 17 2017 
FlingControllerTest.ControllerHandlesGestureFling example:

[ RUN      ] FlingControllerTest.ControllerHandlesGestureFling
../../content/browser/renderer_host/input/fling_controller_unittest.cc:151: Failure
Expected equality of these values:
  WebMouseWheelEvent::kPhaseBegan
    Which is: 1
  last_sent_wheel_.momentum_phase
    Which is: 0
../../content/browser/renderer_host/input/fling_controller_unittest.cc:152: Failure
Expected: (last_sent_wheel_.delta_x) > (0.f), actual: 0 vs 0
../../content/browser/renderer_host/input/fling_controller_unittest.cc:157: Failure
Expected equality of these values:
  WebMouseWheelEvent::kPhaseChanged
    Which is: 4
  last_sent_wheel_.momentum_phase
    Which is: 0
../../content/browser/renderer_host/input/fling_controller_unittest.cc:158: Failure
Expected: (last_sent_wheel_.delta_x) > (0.f), actual: 0 vs 0
[  FAILED  ] FlingControllerTest.ControllerHandlesGestureFling (702 ms)


RenderWidgetHostViewAuraOverscroll*.ScrollEventsOverscrollWithFling example:

[ RUN      ] RenderWidgetHostViewAuraOverscrollWithoutWheelScrollLatchingTest.ScrollEventsOverscrollWithFling
../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4439: Failure
Expected equality of these values:
  OVERSCROLL_NONE
    Which is: 0
  overscroll_mode()
    Which is: 4
../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:4440: Failure
Expected equality of these values:
  OverscrollSource::NONE
    Which is: 4-byte object <00-00 00-00>
  overscroll_source()
    Which is: 4-byte object <01-00 00-00>
[  FAILED  ] RenderWidgetHostViewAuraOverscrollWithoutWheelScrollLatchingTest.ScrollEventsOverscrollWithFling (2014 ms)

FlingControllerTests were added by https://chromium.googlesource.com/chromium/src/+/a29ee211133a9dfa05519e8095fb2023adada13a, which also modified the ScrollEventsOverscrollWithFling test.

Comment 1 by w...@chromium.org, Dec 17 2017

Labels: -Type-Bug Type-Bug-Regression

Comment 2 by w...@chromium.org, Dec 18 2017 

Test failure can be reproduced reliably simply by adding a thread-Sleep() in GiveItSomeTime().  Is there any reason that this test couldn't use mocked time-keeping?
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/635de9474a2529a1f5cd01dd8fac8acabac1af20

commit 635de9474a2529a1f5cd01dd8fac8acabac1af20
Author: Wez <wez@chromium.org>
Date: Mon Dec 18 02:23:01 2017

Disable some flaky FlingController and RenderWidgetHostViewAura tests.

Bug:  795617 
TBR: dtapuska@chromium.org
Change-Id: I9bb71a8556ee6fab4734a29e9525f1cb680d0738
Reviewed-on: https://chromium-review.googlesource.com/831402
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524640}
[modify] https://crrev.com/635de9474a2529a1f5cd01dd8fac8acabac1af20/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/635de9474a2529a1f5cd01dd8fac8acabac1af20/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c00c1189b6358b400bc17e8c62c49e6275f5bb0c

commit c00c1189b6358b400bc17e8c62c49e6275f5bb0c
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed Jan 03 20:18:02 2018

touchpad_browserside_fling_flaky_tests_fixed.

To fix the flakiness the tests are using mock time increment.

Bug:  795617 
Change-Id: I58ac018638ae33e4cd691bf1ea15a47f3b74d80f
Reviewed-on: https://chromium-review.googlesource.com/847461
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526784}
[modify] https://crrev.com/c00c1189b6358b400bc17e8c62c49e6275f5bb0c/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/c00c1189b6358b400bc17e8c62c49e6275f5bb0c/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/c00c1189b6358b400bc17e8c62c49e6275f5bb0c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Comment 5 by sahel@chromium.org, Jan 8 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment